Skip to content

Commit 1f3f2ad

Browse files
authored
Merge pull request #57 from quickwit-oss/ddelemeny-default-and
Use AND as default operator, fixes #54
2 parents ff0ac19 + 2098ac3 commit 1f3f2ad

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

pkg/quickwit/client/models.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,16 @@ type QueryStringFilter struct {
102102
Filter
103103
Query string
104104
AnalyzeWildcard bool
105+
DefaultOperator string
105106
}
106107

107108
// MarshalJSON returns the JSON encoding of the query string filter.
108109
func (f *QueryStringFilter) MarshalJSON() ([]byte, error) {
109110
// FIXME: readd analyze_wildcard when quickwit supports it.
110111
root := map[string]interface{}{
111112
"query_string": map[string]interface{}{
112-
"query": f.Query,
113+
"query": f.Query,
114+
"default_operator": f.DefaultOperator,
113115
// "analyze_wildcard": f.AnalyzeWildcard,
114116
},
115117
}

pkg/quickwit/client/search_request.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -257,14 +257,15 @@ func (b *FilterQueryBuilder) AddDateRangeFilter(timeField string, lteMillisecs i
257257
}
258258

259259
// AddQueryStringFilter adds a new query string filter
260-
func (b *FilterQueryBuilder) AddQueryStringFilter(querystring string, analyseWildcard bool) *FilterQueryBuilder {
260+
func (b *FilterQueryBuilder) AddQueryStringFilter(querystring string, analyseWildcard bool, defaultOperator string) *FilterQueryBuilder {
261261
if len(strings.TrimSpace(querystring)) == 0 {
262262
return b
263263
}
264264

265265
b.filters = append(b.filters, &QueryStringFilter{
266266
Query: querystring,
267267
AnalyzeWildcard: analyseWildcard,
268+
DefaultOperator: defaultOperator,
268269
})
269270
return b
270271
}

pkg/quickwit/client/search_request_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestSearchRequest(t *testing.T) {
4848
b.Sort(SortOrderDesc, timeField, "epoch_nanos_int")
4949
filters := b.Query().Bool().Filter()
5050
filters.AddDateRangeFilter(timeField, 1684398201000, 1684308201000)
51-
filters.AddQueryStringFilter("test", true)
51+
filters.AddQueryStringFilter("test", true, "AND")
5252

5353
t.Run("When building search request", func(t *testing.T) {
5454
sr, err := b.Build()

pkg/quickwit/data_query.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (e *elasticsearchDataQuery) processQuery(q *Query, ms *es.MultiSearchReques
9191
b.Size(0)
9292
filters := b.Query().Bool().Filter()
9393
filters.AddDateRangeFilter(defaultTimeField, to, from)
94-
filters.AddQueryStringFilter(q.RawQuery, true)
94+
filters.AddQueryStringFilter(q.RawQuery, true, "AND")
9595

9696
if isLogsQuery(q) {
9797
processLogsQuery(q, b, from, to, defaultTimeField)

0 commit comments

Comments
 (0)