Raise default log limit to 1000

Author: ddelemeny

src/components/QueryEditor/MetricAggregationsEditor/SettingsEditor/LogsSettingsEditor.tsx

@@ -5,24 +5,26 @@ import { Logs, LogsSortDirection, LogsEnd } from "types";
 import { SettingField } from "./SettingField";
 import { useDispatch } from "hooks/useStatelessReducer";
 import { changeMetricSetting } from '../state/actions';
+import { metricAggregationConfig } from "../utils";
 
 
 // type LogsSortDirection = 'asc' | 'desc'
 
 interface Props { metric: Logs }
 
 export const LogsSettingsEditor = ({metric}: Props)=>{
+  const config = metricAggregationConfig['logs']
   const dispatch = useDispatch();
   return (
     <div className={css({display:"inline-flex", justifyContent:"start", gap:"4px", height:"100%"})} >
       <RadioButtonGroup 
         className={css({height:"100%"})}
         options={Object.values(LogsSortDirection).map((v)=>({label:LogsEnd[v], value:v}))}
-        value={metric.settings?.sortDirection || 'desc' }
+        value={metric.settings?.sortDirection || config.defaults.settings?.sortDirection }
         onChange={(v)=>{ dispatch(
             changeMetricSetting({ metric, settingName: 'sortDirection', newValue: v })
           )}}/>
-      <SettingField label="Limit" metric={metric} settingName="limit" placeholder="100" />
+      <SettingField label="Limit" metric={metric} settingName="limit" placeholder={config.defaults.settings?.limit} />
     </div>
   )
 

src/components/QueryEditor/MetricAggregationsEditor/SettingsEditor/useDescription.ts

@@ -1,5 +1,6 @@
 import { extendedStats } from 'queryDef';
 import { Logs, LogsEnd, MetricAggregation } from '@/types';
+import { metricAggregationConfig } from '../utils';
 
 const hasValue = (value: string) => (object: { value: string }) => object.value === value;
 
@@ -35,8 +36,9 @@ export const useDescription = (metric: MetricAggregation): string => {
     }
 
     case 'logs': {
+      const config = metricAggregationConfig['logs']
       const logsmetric: Logs = metric
-      const sort = LogsEnd[logsmetric.settings?.sortDirection || "desc"]
+      const sort = LogsEnd[logsmetric.settings?.sortDirection || config.defaults.settings!.sortDirection!]
       const limit = logsmetric.settings?.limit || 100
       return `${sort} ${limit}`
     }

src/components/QueryEditor/MetricAggregationsEditor/utils.ts

@@ -243,7 +243,7 @@ export const metricAggregationConfig: MetricsConfiguration = {
     hasMeta: false,
     defaults: {
       settings: {
-        limit: '100',
+        limit: '1000',
         sortDirection:'desc' as LogsSortDirection
       },
     },

src/queryDef.ts

@@ -32,7 +32,7 @@ export function defaultMetricAgg(id = '1'): MetricAggregation {
 }
 
 export function defaultLogsAgg(id = '1'): MetricAggregation {
-  return { type: 'logs', id };
+  return { type: 'logs', id, ...metricAggregationConfig['logs'].defaults };
 }
 
 export function defaultBucketAgg(id = '1'): DateHistogram {

src/types.ts

@@ -75,7 +75,7 @@ interface MetricConfiguration<T extends MetricAggregationType> {
   impliedQueryType: QueryType;
   hasSettings: boolean;
   hasMeta: boolean;
-  defaults: Omit<Extract<MetricAggregation|Logs, { type: T }>, 'id' | 'type'>;
+  defaults: Omit<Extract<Exclude<MetricAggregation,SchemaLogs>|Logs, { type: T }>, 'id' | 'type'>;
 }
 
 type BucketConfiguration<T extends BucketAggregationType> = {