Skip to content

Commit 455f759

Browse files
fulmicotonfulmicoton-ddguilload
authored
Upgrading tonic, http, hyper, tower. (#5777)
* Upgrading tonic, http, hyper, tower. We keep using hyper 0.2 in the quickwit-serve crate because of warp. * Fix compile errors and clippy warnings * Update LICENSE-3rdparty.csv file * Fix cargo deny --------- Co-authored-by: fulmicoton <[email protected]> Co-authored-by: Adrien Guillo <[email protected]>
1 parent 4ab01ea commit 455f759

File tree

87 files changed

+2581
-2715
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+2581
-2715
lines changed

LICENSE-3rdparty.csv

Lines changed: 8 additions & 22 deletions
Large diffs are not rendered by default.

quickwit/Cargo.lock

Lines changed: 617 additions & 679 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

quickwit/Cargo.toml

Lines changed: 29 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@ dyn-clone = "1.0.10"
108108
enum-iterator = "1.5"
109109
env_logger = "0.10"
110110
fail = "0.5"
111+
flate2 = "1.0"
111112
flume = "0.11"
112113
fnv = "1"
113-
flate2 = "1.0"
114114
futures = "0.3"
115115
futures-util = { version = "0.3.25", default-features = false }
116116
glob = "0.3"
@@ -122,24 +122,19 @@ heck = "0.4.1"
122122
hex = "0.4.3"
123123
home = "0.5.4"
124124
hostname = "0.3"
125-
http = "0.2.9"
125+
http = "1.3"
126+
http-body-util = "0.1.3"
126127
http-serde = "1.1.2"
127128
humantime = "2.1.0"
128-
hyper = { version = "0.14", features = [
129-
"client",
130-
"http1",
131-
"http2",
132-
"server",
133-
"stream",
134-
"tcp",
135-
] }
129+
hyper = { version = "1.6", features = ["client", "http1", "http2", "server"] }
136130
hyper-rustls = "0.24"
131+
hyper-util = { version = "0.1", features = ["full"] }
137132
indexmap = { version = "2.1.0", features = ["serde"] }
138133
indicatif = "0.17.3"
139134
itertools = "0.13"
140135
json_comments = "0.2"
136+
legacy-http = { version = "0.2.9", package = "http" }
141137
libz-sys = "1.1.8"
142-
lru = "0.13"
143138
lindera-core = "0.27.0"
144139
lindera-dictionary = "0.27.0"
145140
lindera-tokenizer = { version = "0.27.0", features = [
@@ -150,6 +145,7 @@ lindera-tokenizer = { version = "0.27.0", features = [
150145
"ko-dic-compress",
151146
"ko-dic",
152147
] }
148+
lru = "0.13"
153149
matches = "0.1.9"
154150
md5 = "0.7"
155151
mime_guess = "2.0.4"
@@ -172,17 +168,17 @@ pnet = { version = "0.33.0", features = ["std"] }
172168
postcard = { version = "1.0.4", features = [
173169
"use-std",
174170
], default-features = false }
171+
pprof = { version = "0.13", features = ["flamegraph"] }
175172
predicates = "3"
176173
prettyplease = "0.2.0"
177-
pprof = { version = "0.13", features = ["flamegraph"] }
178174
proc-macro2 = "1.0.50"
179175
prometheus = { version = "0.13", features = ["process"] }
180176
proptest = "1"
181-
prost = { version = "0.11.6", default-features = false, features = [
177+
prost = { version = "0.13", default-features = false, features = [
182178
"prost-derive",
183179
] }
184-
prost-build = "0.11.6"
185-
prost-types = "0.11.6"
180+
prost-build = "0.13"
181+
prost-types = "0.13"
186182
pulsar = { version = "6.3", default-features = false, features = [
187183
"auth-oauth2",
188184
"compression",
@@ -248,20 +244,25 @@ tokio-rustls = { version = "0.24.0", default-features = false }
248244
tokio-stream = { version = "0.1", features = ["sync"] }
249245
tokio-util = { version = "0.7", features = ["full"] }
250246
toml = "0.7.6"
251-
tonic = { version = "0.9.0", features = ["gzip"] }
252-
tonic-build = "0.9.0"
253-
tonic-health = "0.9.0"
254-
tonic-reflection = "0.9"
255-
tower = { version = "0.4.13", features = [
247+
tonic = { version = "0.13.0", features = [
248+
"gzip",
249+
"_tls-any",
250+
"tls-native-roots",
251+
] }
252+
tonic-build = "0.13.0"
253+
tonic-health = "0.13.0"
254+
tonic-reflection = "0.13"
255+
tower = { version = "0.5", features = [
256256
"balance",
257257
"buffer",
258258
"load",
259259
"retry",
260260
"util",
261261
] }
262-
tower-http = { version = "0.4.0", features = [
263-
"compression-zstd",
262+
# legacy version because of warp
263+
tower-http = { version = "0.4", features = [
264264
"compression-gzip",
265+
"compression-zstd",
265266
"cors",
266267
] }
267268
tracing = "0.1"
@@ -286,7 +287,7 @@ vrl = { version = "0.22", default-features = false, features = [
286287
] }
287288
warp = "0.3"
288289
whichlang = "0.1"
289-
wiremock = "0.5"
290+
wiremock = "0.6"
290291
zstd = "0.13.0"
291292

292293
aws-config = "1.5.4"
@@ -296,8 +297,12 @@ aws-sdk-kinesis = "1.37"
296297
aws-sdk-s3 = "=1.62"
297298
aws-sdk-sqs = "1.36"
298299
aws-smithy-async = "1.2"
300+
aws-smithy-http-client = { version = "1.0" }
299301
aws-smithy-runtime = "1.6.2"
300-
aws-smithy-types = { version = "1.2", features = ["byte-stream-poll-next"] }
302+
aws-smithy-types = { version = "1.2", features = [
303+
"byte-stream-poll-next",
304+
"http-body-1-x",
305+
] }
301306
aws-types = "1.3.3"
302307

303308
azure_core = { version = "0.13.0", features = ["enable_reqwest_rustls"] }

quickwit/deny.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ allow = [
5858
"BSD-2-Clause",
5959
"BSD-3-Clause",
6060
"CC0-1.0",
61+
"CDLA-Permissive-2.0",
6162
"ISC",
6263
"MIT",
6364
"MPL-2.0",
64-
"OpenSSL",
6565
"Unicode-3.0",
6666
"Unlicense",
6767
"Zlib",

quickwit/quickwit-aws/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@ aws-sdk-kinesis = { workspace = true, optional = true }
1717
aws-sdk-s3 = { workspace = true }
1818
aws-sdk-sqs = { workspace = true, optional = true }
1919
aws-smithy-async = { workspace = true }
20+
aws-smithy-http-client = { workspace = true }
2021
aws-smithy-runtime = { workspace = true }
2122
aws-types = { workspace = true }
2223

2324
futures = { workspace = true }
25+
http-body-util = { workspace = true }
2426
hyper = { workspace = true }
2527
hyper-rustls = { workspace = true }
2628
tokio = { workspace = true }

quickwit/quickwit-aws/src/lib.rs

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,10 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
use std::time::Duration;
16-
17-
use aws_config::BehaviorVersion;
1815
use aws_config::retry::RetryConfig;
1916
use aws_config::stalled_stream_protection::StalledStreamProtectionConfig;
17+
use aws_config::{BehaviorVersion, Region};
2018
pub use aws_smithy_async::rt::sleep::TokioSleep;
21-
use aws_smithy_runtime::client::http::hyper_014::HyperClientBuilder;
22-
use aws_types::region::Region;
23-
use hyper::Client as HyperClient;
24-
use hyper::client::HttpConnector;
25-
use hyper_rustls::HttpsConnectorBuilder;
2619
use tokio::sync::OnceCell;
2720

2821
pub mod error;
@@ -36,31 +29,8 @@ pub async fn get_aws_config() -> &'static aws_config::SdkConfig {
3629

3730
SDK_CONFIG
3831
.get_or_init(|| async {
39-
let mut http_connector = HttpConnector::new();
40-
http_connector.enforce_http(false); // Enforced by `HttpsConnector`.
41-
http_connector.set_nodelay(true);
42-
43-
let https_connector = HttpsConnectorBuilder::new()
44-
.with_native_roots()
45-
.https_or_http()
46-
// We do not enable HTTP2.
47-
// It is not enabled on S3 and it does not seem to work with Google Cloud Storage at
48-
// this point. https://github.com/quickwit-oss/quickwit/issues/1584
49-
//
50-
// (HTTP2 would be awesome since we do a lot of concurrent requests and
51-
// HTTP2 enables multiplexing a given connection.)
52-
.enable_http1()
53-
.wrap_connector(http_connector);
54-
55-
let mut hyper_client_builder = HyperClient::builder();
56-
hyper_client_builder.pool_idle_timeout(Duration::from_secs(30));
57-
let hyper_client = HyperClientBuilder::new()
58-
.hyper_builder(hyper_client_builder)
59-
.build(https_connector);
60-
6132
aws_config::defaults(aws_behavior_version())
6233
.stalled_stream_protection(StalledStreamProtectionConfig::enabled().build())
63-
.http_client(hyper_client)
6434
// Currently handle this ourselves so probably best for now to leave it as is.
6535
.retry_config(RetryConfig::disabled())
6636
.sleep_impl(TokioSleep::default())

0 commit comments

Comments
 (0)