Skip to content

Commit fe0f39a

Browse files
wait for merge at end of local ingest (#5542)
1 parent 23289a1 commit fe0f39a

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

quickwit/quickwit-cli/src/tool.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,11 @@ pub async fn local_ingest_docs_cli(args: LocalIngestDocsArgs) -> anyhow::Result<
495495
let statistics =
496496
start_statistics_reporting_loop(indexing_pipeline_handle, args.input_path_opt.is_none())
497497
.await?;
498-
merge_pipeline_handle.quit().await;
498+
merge_pipeline_handle
499+
.mailbox()
500+
.ask(quickwit_indexing::FinishPendingMergesAndShutdownPipeline)
501+
.await?;
502+
merge_pipeline_handle.join().await;
499503
// Shutdown the indexing server.
500504
universe
501505
.send_exit_with_success(&indexing_server_mailbox)

quickwit/quickwit-indexing/src/actors/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ pub use indexer::{Indexer, IndexerCounters};
4141
pub use indexing_pipeline::{IndexingPipeline, IndexingPipelineParams};
4242
pub use indexing_service::{IndexingService, IndexingServiceCounters, INDEXING_DIR_NAME};
4343
pub use merge_executor::{combine_partition_ids, merge_split_attrs, MergeExecutor};
44-
pub use merge_pipeline::MergePipeline;
44+
pub use merge_pipeline::{FinishPendingMergesAndShutdownPipeline, MergePipeline};
4545
pub(crate) use merge_planner::{MergePlanner, RunFinalizeMergePolicyAndQuit};
4646
pub use merge_scheduler_service::{schedule_merge, MergePermit, MergeSchedulerService};
4747
pub use merge_split_downloader::MergeSplitDownloader;

quickwit/quickwit-indexing/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ use tracing::info;
3131

3232
use crate::actors::MergeSchedulerService;
3333
pub use crate::actors::{
34-
IndexingError, IndexingPipeline, IndexingPipelineParams, IndexingService, PublisherType,
35-
Sequencer, SplitsUpdateMailbox,
34+
FinishPendingMergesAndShutdownPipeline, IndexingError, IndexingPipeline,
35+
IndexingPipelineParams, IndexingService, PublisherType, Sequencer, SplitsUpdateMailbox,
3636
};
3737
pub use crate::controlled_directory::ControlledDirectory;
3838
use crate::models::IndexingStatistics;

0 commit comments

Comments
 (0)