Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qprep charge groups ambivalent indexing shows no error #5

Open
dblahanelson opened this issue Nov 28, 2017 · 2 comments
Open

qprep charge groups ambivalent indexing shows no error #5

dblahanelson opened this issue Nov 28, 2017 · 2 comments

Comments

@dblahanelson
Copy link

I made a topology in qprep using a library that had charge groups containing two H43's and no H42's, e.g. when making charge groups, I accidentally labelled H42 as H43 while also naming H43 as H43. Qprep made that topology with no errors. One should, of course, be more careful. Still, it might be useful if qprep noticed the charge groups made no sense.

@acmnpv
Copy link
Contributor

acmnpv commented Jan 12, 2018

Hello, if you could upload a test case I could have a look at fixing this, thank you!

@dblahanelson
Copy link
Author

dblahanelson commented Jan 12, 2018

In this example, both libraries have atoms H42 and C43 listed in [atoms], neither has an H43 listed.

In [charge_groups], the correct library has H42 in one charge group and C43 in another charge group. The incorrect library has H43 in one charge group, C43 in another charge group and no H42 at all, even though H42 exists and H43 doesn't. Both create topologies successfully and have identical log files.

I propose that charge groups cannot have atoms that aren't listed in [atoms], or that it at least throws an error.

test_case.zip

@acmnpv acmnpv mentioned this issue Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants