Merge pull request #547 from rabbitmq/renewal-creds

ChunyiLyu · web-flow · commit 1347b2c8b7f1 · 2023-02-06T15:14:07.000Z
Stop logging renewal info to avoid leaking creds.
diff --git a/rabbitmqclient/vault_reader.go b/rabbitmqclient/vault_reader.go
@@ -273,8 +273,8 @@ func manageTokenLifecycle(client *vault.Client, token *vault.Secret) error {
 			return nil
 
 		// Successfully completed renewal
-		case renewal := <-watcher.RenewCh():
-			logger.Info("Successfully renewed Vault token", "renewal info", renewal)
+		case <-watcher.RenewCh():
+			logger.Info("Successfully renewed Vault token")
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -273,8 +273,8 @@ func manageTokenLifecycle(client vault.Client, token vault.Secret) error {`
`273`	`273`	`return nil`
`274`	`274`
`275`	`275`	`// Successfully completed renewal`
`276`		`- case renewal := <-watcher.RenewCh():`
`277`		`- logger.Info("Successfully renewed Vault token", "renewal info", renewal)`
	`276`	`+ case <-watcher.RenewCh():`
	`277`	`+ logger.Info("Successfully renewed Vault token")`
`278`	`278`	`}`
`279`	`279`	`}`
`280`	`280`	`}`