Use named errors for URI parsing

Author: camelpunch

RMQClient/RMQErrors.h

@@ -12,4 +12,7 @@ typedef NS_ENUM(NSInteger, RMQError) {
     RMQErrorChannelWaitTimeout,
     RMQErrorChannelIncorrectSyncMethod,
     RMQErrorChannelQueueNameCollision,
+
+    RMQErrorInvalidPath,
+    RMQErrorInvalidScheme,
 };

RMQClient/RMQURI.m

@@ -17,7 +17,7 @@ + (instancetype)parse:(NSString *)uri error:(NSError *__autoreleasing  _Nullable
 
     if (![self isValidScheme:components.scheme]) {
         *error = [NSError errorWithDomain:RMQErrorDomain
-                                     code:0
+                                     code:RMQErrorInvalidScheme
                                  userInfo:@{NSLocalizedDescriptionKey: NSLocalizedString(@"Connection URI must use amqp or amqps schema (example: amqp://bus.megacorp.internal:5766), learn more at http://bit.ly/ks8MXK", nil)}];
         return nil;
     }
@@ -61,7 +61,7 @@ + (NSString *)parseVhost:(NSURLComponents *)components error:(NSError **)error {
 
     if (numberOfSlashes > 2) {
         NSString *msg = [NSString stringWithFormat:@"%@ has multiple-segment path; please percent-encode any slashes in the vhost name (e.g. /production => %%2Fproduction). Learn more at http://bit.ly/amqp-gem-and-connection-uris", components.URL];
-        *error = [NSError errorWithDomain:RMQErrorDomain code:0 userInfo:@{NSLocalizedDescriptionKey: NSLocalizedString(msg, nil)}];
+        *error = [NSError errorWithDomain:RMQErrorDomain code:RMQErrorInvalidPath userInfo:@{NSLocalizedDescriptionKey: NSLocalizedString(msg, nil)}];
         return nil;
     } else if (components.path.length == 0) {
         return @"/";

RMQClientTests/RMQURIParseTest.swift

@@ -3,11 +3,11 @@ import XCTest
 class RMQURIParseTest: XCTestCase {
 
     func testNonAMQPSchemesNotAllowed() {
-        XCTAssertThrowsError(try RMQURI.parse("amqpfoo://dev.rabbitmq.com")) { (error) in
+        XCTAssertThrowsError(try RMQURI.parse("amqpfoo://dev.rabbitmq.com")) { error in
             do {
                 XCTAssertEqual(
-                    "Connection URI must use amqp or amqps schema (example: amqp://bus.megacorp.internal:5766), learn more at http://bit.ly/ks8MXK",
-                    (error as NSError).localizedDescription
+                    RMQError.InvalidScheme.rawValue,
+                    (error as NSError).code
                 )
             }
         }
@@ -50,8 +50,8 @@ class RMQURIParseTest: XCTestCase {
         XCTAssertThrowsError(try RMQURI.parse("amqp://dev.rabbitmq.com/a/path/with/slashes")) { (error) in
             do {
                 XCTAssertEqual(
-                    "amqp://dev.rabbitmq.com/a/path/with/slashes has multiple-segment path; please percent-encode any slashes in the vhost name (e.g. /production => %2Fproduction). Learn more at http://bit.ly/amqp-gem-and-connection-uris",
-                    (error as NSError).localizedDescription
+                    RMQError.InvalidPath.rawValue,
+                    (error as NSError).code
                 )
             }
         }