Skip to content
This repository was archived by the owner on Mar 30, 2021. It is now read-only.

Commit e13317c

Browse files
Merge pull request #604 from radiant-player/hotfix-nav-bar
Hotfix issue with nav-container attributes
2 parents a87c9d9 + 347ce3d commit e13317c

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ This file should follow the standards specified on [keepachangelog.com](http://k
44
This project adheres to [Semantic Versioning](http://semver.org/).
55

66
## [unreleased]
7+
### Fixed
8+
* Hotfixed navigation bar issue causing crashes ([#604](https://github.com/radiant-player/radiant-player-mac/pull/604))
79

810
## [1.10.2] - 2016-08-19
911
### Fixed

radiant-player-mac/js/navigation.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ if (typeof window.GMNavigation === 'undefined') {
6767
buttonsContainer.parentNode.insertBefore(paddingElement, buttonsContainer);
6868

6969
// Adjust the drawer navigation scrolling mode to accomodate the traffic light buttons.
70-
var el = document.querySelector('#drawer #nav-container');
71-
if (el) el.setAttribute('mode', '');
70+
var navContainer = document.querySelector('#drawer #nav-container');
71+
if (navContainer) {
72+
navContainer.removeAttribute('mode');
73+
var mode = document.createAttribute('mode');
74+
mode.value = '';
75+
navContainer.setAttributeNode(mode);
76+
}
7277
}

0 commit comments

Comments
 (0)