Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description about adding the configuration to config file to help command #67

Open
radlinskii opened this issue Oct 19, 2024 · 5 comments
Assignees
Labels

Comments

@radlinskii
Copy link
Owner

currently help command displays detailed information about configuration passed as arguments, but has zero information about adding default configuration to the config file and it's path

@Aditya-PS-05
Copy link

Please assign it to me.

@Aditya-PS-05
Copy link

I need more description to work upon it. Can you provide it?

@radlinskii
Copy link
Owner Author

ah sure, so by help command I mean when you run

donkeytype --help or donkeytype help or during development it's cargo run -- --help or cargo run --help

When you run it, you get detailed information about the possible arguments and different ways you can start the app, but there is no information about adding configuration of the app to e.g. ~/.config/donkeytype.config.json file.

It is described in the readme https://github.com/radlinskii/donkeytype?tab=readme-ov-file#configuration and should be added as well as description to the help command.

I think the possible solution is to provide description to long_about to

#[command(author, version, about = "donkeytype - a very minimalistic cli typing test", long_about = None)]

@Aditya-PS-05
Copy link

Aditya-PS-05 commented Oct 22, 2024

long_about = "donkeytype is a minimalistic CLI typing test. You can configure options like duration, number inclusion, symbols, and uppercase letters either via command-line arguments or by using a config file.

To set default configurations, create a JSON file at ~/.config/donkeytype/donkeytype-config.json. This allows setting parameters such as duration, dictionary path, ratios, and even custom colors for correct and incorrect matches.

Example config:
{
    \"duration\": 60,
    \"dictionary_path\": \"/usr/share/dict/words\",
    \"uppercase_ratio\": 0.3,
    \"colors\": { \"correct_match_fg\": \"green\" }
}

For full details, see the README."

Is this description good.

  • Tells about Donkey Type.
  • Different Configurations Types and how to add them.
  • How to add configurations using config file.
  • Example to add the configurations.
  • More about configurations in README.

I know this being much longer. Any suggestions or review to make it shorter to look good or do you like it,

@radlinskii
Copy link
Owner Author

The only issue with it is that I think on different OS the path to the co fig is different, not sure if we can determine which is it is and display different path here, or just write that on different OS it can be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants