Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem adding mruby-onig-regexp #4

Closed
esb opened this issue Apr 9, 2020 · 5 comments
Closed

Problem adding mruby-onig-regexp #4

esb opened this issue Apr 9, 2020 · 5 comments

Comments

@esb
Copy link

esb commented Apr 9, 2020

I've updated my engine.gembox and added

conf.gem(github: "mattn/mruby-onig-regexp", branch: "master")

The build however is confounding me. It's failing because the autoconf is generating

./configure --disable-shared --enable-static --host sandbox

The host parameter 'sandbox' is throwing things out and as far as I can tell, shouldn't even be there.

Any guidance would be appreciated as I have no idea where this is coming from.

@jasl
Copy link
Member

jasl commented Apr 9, 2020

I'll check this later

sandbox is a target that disable stdio (which means gems which has IO won't be supported), your script will running in it.

@jasl
Copy link
Member

jasl commented Apr 9, 2020

@esb could you try the master branch?

@jasl
Copy link
Member

jasl commented Apr 9, 2020

I've solved the problem,
because ESS don't set host_target when compiling sandbox,
because host = "--host #{build.host_target ? build.host_target : build.name}"
mruby-onig-regexp would assuming build.name ("sandbox" in this case) is the arch name if host_target not specified, but of course not, so the error occurred.

I do a simple fix 84ab4ae

and have tested on my machine (macOS 10.15)

@esb
Copy link
Author

esb commented Apr 10, 2020

Thanks. That seems to resolve the problem.

@esb esb closed this as completed Apr 10, 2020
@jasl
Copy link
Member

jasl commented Apr 10, 2020

I'll release a new version tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants