Merge pull request #823 from rails-sqlserver/enable-frozen-strings-part-3

Enable frozen strings - final

Author: wpolicarpo

CHANGELOG.md

@@ -17,6 +17,7 @@
 - [#820](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/820) Enable frozen strings for tests
 - [#821](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/821) Enable frozen strings - part 1
 - [#822](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/822) Enable frozen strings - part 2
+- [#823](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/823) Enable frozen strings - final
 
 #### Added
 

lib/active_record/connection_adapters/sqlserver/database_limits.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -342,7 +344,7 @@ def sp_executesql_sql(sql, types, params, name)
             types = quote(types.join(', '))
             params = params.map.with_index{ |p, i| "@#{i} = #{p}" }.join(', ') # Only p is needed, but with @i helps explain regexp.
             sql = "EXEC sp_executesql #{quote(sql)}"
-            sql << ", #{types}, #{params}" unless params.empty?
+            sql += ", #{types}, #{params}" unless params.empty?
           end
           sql
         end

lib/active_record/connection_adapters/sqlserver/database_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
 
   class DeadlockVictim < WrappedDatabaseException

lib/active_record/connection_adapters/sqlserver/quoting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/schema_creation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/schema_dumper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -152,8 +154,9 @@ def change_column(table_name, column_name, type, options = {})
             remove_indexes(table_name, column_name)
           end
           sql_commands << "UPDATE #{quote_table_name(table_name)} SET #{quote_column_name(column_name)}=#{quote_default_expression(options[:default], column_object)} WHERE #{quote_column_name(column_name)} IS NULL" if !options[:null].nil? && options[:null] == false && !options[:default].nil?
-          sql_commands << "ALTER TABLE #{quote_table_name(table_name)} ALTER COLUMN #{quote_column_name(column_name)} #{type_to_sql(type, limit: options[:limit], precision: options[:precision], scale: options[:scale])}"
-          sql_commands.last << ' NOT NULL' if !options[:null].nil? && options[:null] == false
+          alter_command = "ALTER TABLE #{quote_table_name(table_name)} ALTER COLUMN #{quote_column_name(column_name)} #{type_to_sql(type, limit: options[:limit], precision: options[:precision], scale: options[:scale])}"
+          alter_command += ' NOT NULL' if !options[:null].nil? && options[:null] == false
+          sql_commands << alter_command
           if without_constraints
             default = quote_default_expression(default, column_object || column_for(table_name, column_name))
             sql_commands << "ALTER TABLE #{quote_table_name(table_name)} ADD CONSTRAINT #{default_constraint_name(table_name, column_name)} DEFAULT #{default} FOR #{quote_column_name(column_name)}"
@@ -267,7 +270,7 @@ def change_column_null(table_name, column_name, allow_null, default = nil)
             do_execute("UPDATE #{table_id} SET #{column_id}=#{quote(default)} WHERE #{column_id} IS NULL")
           end
           sql = "ALTER TABLE #{table_id} ALTER COLUMN #{column_id} #{type_to_sql column.type, limit: column.limit, precision: column.precision, scale: column.scale}"
-          sql << ' NOT NULL' if !allow_null.nil? && allow_null == false
+          sql += ' NOT NULL' if !allow_null.nil? && allow_null == false
           do_execute sql
         end
 
@@ -281,12 +284,12 @@ def data_source_sql(name = nil, type: nil)
           scope = quoted_scope name, type: type
           table_name = lowercase_schema_reflection_sql 'TABLE_NAME'
           sql = "SELECT #{table_name}"
-          sql << ' FROM INFORMATION_SCHEMA.TABLES WITH (NOLOCK)'
-          sql << ' WHERE TABLE_CATALOG = DB_NAME()'
-          sql << " AND TABLE_SCHEMA = #{quote(scope[:schema])}"
-          sql << " AND TABLE_NAME = #{quote(scope[:name])}" if scope[:name]
-          sql << " AND TABLE_TYPE = #{quote(scope[:type])}" if scope[:type]
-          sql << " ORDER BY #{table_name}"
+          sql += ' FROM INFORMATION_SCHEMA.TABLES WITH (NOLOCK)'
+          sql += ' WHERE TABLE_CATALOG = DB_NAME()'
+          sql += " AND TABLE_SCHEMA = #{quote(scope[:schema])}"
+          sql += " AND TABLE_NAME = #{quote(scope[:name])}" if scope[:name]
+          sql += " AND TABLE_TYPE = #{quote(scope[:type])}" if scope[:type]
+          sql += " ORDER BY #{table_name}"
           sql
         end
 

lib/active_record/connection_adapters/sqlserver/showplan.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/connection_adapters/sqlserver/showplan/printer_table'
 require 'active_record/connection_adapters/sqlserver/showplan/printer_xml'
 

lib/active_record/connection_adapters/sqlserver/sql_type_metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/table_definition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver/transaction.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/connection_adapters/abstract/transaction'
 
 module ActiveRecord

lib/active_record/connection_adapters/sqlserver/type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/type'
 # Behaviors
 require 'active_record/connection_adapters/sqlserver/type/data'

lib/active_record/connection_adapters/sqlserver/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'strscan'
 
 module ActiveRecord

lib/active_record/connection_adapters/sqlserver/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 require 'active_record'
 require 'arel_sqlserver'

lib/active_record/connection_adapters/sqlserver_column.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     class SQLServerColumn < Column

lib/active_record/sqlserver_base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionHandling
     def sqlserver_connection(config) #:nodoc:

lib/active_record/tasks/sqlserver_database_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/tasks/database_tasks'
 require 'shellwords'
 require 'ipaddr'

lib/activerecord-sqlserver-adapter.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'active_record/connection_adapters/sqlserver_adapter'

lib/arel/visitors/sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Arel
   module Visitors
     class SQLServer < Arel::Visitors::ToSql

lib/arel_sqlserver.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require 'arel'
 require 'arel/visitors/sqlserver'