Skip to content

Commit 4b8da98

Browse files
jvon1904Jesse vonBergen
and
Jesse vonBergen
authored
Exclude "guest" schmea in schema dumper (#1208)
Co-authored-by: Jesse vonBergen <[email protected]>
1 parent b62e362 commit 4b8da98

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Diff for: lib/active_record/connection_adapters/sqlserver/schema_statements.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ def schema_names
400400
FROM sys.schemas
401401
WHERE
402402
name NOT LIKE 'db_%' AND
403-
name NOT IN ('INFORMATION_SCHEMA', 'sys')
403+
name NOT IN ('INFORMATION_SCHEMA', 'sys', 'guest')
404404
SQL
405405

406406
query_values(sql, "SCHEMA")

Diff for: test/cases/schema_dumper_test_sqlserver.rb

+4
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,10 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
167167

168168
# Only generate non-default schemas. Default schema is 'dbo'.
169169
assert_not_includes generated_schema, 'create_schema "dbo"'
170+
assert_not_includes generated_schema, 'create_schema "db_owner"'
171+
assert_not_includes generated_schema, 'create_schema "INFORMATION_SCHEMA"'
172+
assert_not_includes generated_schema, 'create_schema "sys"'
173+
assert_not_includes generated_schema, 'create_schema "guest"'
170174
assert_includes generated_schema, 'create_schema "test"'
171175
assert_includes generated_schema, 'create_schema "test2"'
172176

0 commit comments

Comments
 (0)