Skip to content

Commit abba3c8

Browse files
authored
Merge pull request #824 from rails-sqlserver/tidy-up-gemfile
Tidy up Gemfile
2 parents faa480b + 3a4231b commit abba3c8

File tree

3 files changed

+46
-42
lines changed

3 files changed

+46
-42
lines changed

.editorconfig

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
root = true
2+
3+
[*]
4+
indent_style = space
5+
indent_size = 2
6+
end_of_line = lf
7+
charset = utf-8
8+
trim_trailing_whitespace = true
9+
insert_final_newline = true

CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
#### Fixed
44

5-
- [#690](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/690) Rails 6 support
5+
- [#690](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/690) Rails 6 support
66
- [#805](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/805) Rails 6: Fix database tasks tests for SQL Server
77
- [#807](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/807) Rails 6: Skip binary fixtures test on Windows
88
- [#809](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/809) Rails 6: Coerce reaper test using fork
@@ -19,6 +19,7 @@
1919
- [#821](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/821) Enable frozen strings - part 1
2020
- [#822](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/822) Enable frozen strings - part 2
2121
- [#823](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/823) Enable frozen strings - final
22+
- [#824](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/824) Tidy up Gemfile
2223

2324
#### Added
2425

Gemfile

+35-41
Original file line numberDiff line numberDiff line change
@@ -1,69 +1,63 @@
11
# frozen_string_literal: true
22

3-
require 'openssl'
4-
source 'https://rubygems.org'
3+
source "https://rubygems.org"
54

65
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
76

87
gemspec
98

9+
gem "bcrypt"
10+
gem "pg", ">= 0.18.0"
1011
gem "sqlite3", "~> 1.4"
11-
gem "pg", ">= 0.18.0"
12+
gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
1213

13-
gem 'bcrypt'
14-
gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
15-
16-
if RbConfig::CONFIG["host_os"] =~ /darwin/
17-
gem 'terminal-notifier-guard'
18-
end
19-
20-
if ENV['RAILS_SOURCE']
21-
gemspec path: ENV['RAILS_SOURCE']
14+
if ENV["RAILS_SOURCE"]
15+
gemspec path: ENV["RAILS_SOURCE"]
2216
else
2317
# Need to get rails source because the gem doesn't include tests
24-
version = ENV['RAILS_VERSION'] || begin
25-
require 'net/http'
26-
require 'yaml'
27-
spec = eval(File.read('activerecord-sqlserver-adapter.gemspec'))
28-
ver = spec.dependencies.detect{ |d|d.name == 'activerecord' }.requirement.requirements.first.last.version
29-
major, minor, tiny, pre = ver.split('.')
30-
if !pre
31-
uri = URI.parse "https://rubygems.org/api/v1/versions/activerecord.yaml"
18+
version = ENV["RAILS_VERSION"] || begin
19+
require "openssl"
20+
require "net/http"
21+
require "yaml"
22+
23+
spec = eval(File.read("activerecord-sqlserver-adapter.gemspec"))
24+
ver = spec.dependencies.detect{ |d|d.name == "activerecord" }.requirement.requirements.first.last.version
25+
major, minor, tiny, pre = ver.split(".")
26+
27+
if pre
28+
ver
29+
else
30+
uri = URI.parse("https://rubygems.org/api/v1/versions/activerecord.yaml")
3231
http = Net::HTTP.new(uri.host, uri.port)
3332
http.use_ssl = true
3433
http.verify_mode = OpenSSL::SSL::VERIFY_NONE
35-
YAML.load(http.request(Net::HTTP::Get.new(uri.request_uri)).body).select do |data|
36-
a, b, c = data['number'].split('.')
37-
!data['prerelease'] && major == a && (minor.nil? || minor == b)
38-
end.first['number']
39-
else
40-
ver
34+
YAML.load(http.request(Net::HTTP::Get.new(uri.request_uri)).body).find do |data|
35+
a, b, c = data["number"].split(".")
36+
!data["prerelease"] && major == a && (minor.nil? || minor == b)
37+
end["number"]
4138
end
4239
end
43-
gem 'rails', github: "rails/rails", tag: "v#{version}"
44-
end
45-
46-
if ENV['AREL']
47-
gem 'arel', path: ENV['AREL']
40+
gem "rails", github: "rails/rails", tag: "v#{version}"
4841
end
4942

5043
group :tinytds do
51-
if ENV['TINYTDS_SOURCE']
52-
gem 'tiny_tds', path: ENV['TINYTDS_SOURCE']
53-
elsif ENV['TINYTDS_VERSION']
54-
gem 'tiny_tds', ENV['TINYTDS_VERSION']
44+
if ENV["TINYTDS_SOURCE"]
45+
gem "tiny_tds", path: ENV["TINYTDS_SOURCE"]
46+
elsif ENV["TINYTDS_VERSION"]
47+
gem "tiny_tds", ENV["TINYTDS_VERSION"]
5548
else
56-
gem 'tiny_tds'
49+
gem "tiny_tds"
5750
end
5851
end
5952

6053
group :development do
61-
gem 'byebug', platform: [:mri, :mingw, :x64_mingw]
62-
gem 'mocha'
63-
gem 'minitest-spec-rails'
54+
gem "pry-byebug", platform: [:mri, :mingw, :x64_mingw]
55+
gem "mocha"
56+
gem "minitest-spec-rails"
6457
end
6558

6659
group :guard do
67-
gem 'guard'
68-
gem 'guard-minitest'
60+
gem "guard"
61+
gem "guard-minitest"
62+
gem "terminal-notifier-guard" if RbConfig::CONFIG["host_os"] =~ /darwin/
6963
end

0 commit comments

Comments
 (0)