Merge pull request #820 from rails-sqlserver/enable-frozen-strings-for-tests

wpolicarpo · web-flow · commit e6e0f29f59a5 · 2020-05-13T23:19:56.000+01:00
Enable frozen strings for tests
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@
 
 - [#763](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/763) Refactor columns introspection query to make it faster
 - [#783](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/783) Update test matrix
+- [#820](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/820) Enable frozen strings for tests
 
 #### Added
 
diff --git a/test/cases/adapter_test_sqlserver.rb b/test/cases/adapter_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/topic'
 require 'models/task'
diff --git a/test/cases/change_column_null_test_sqlserver.rb b/test/cases/change_column_null_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'migrations/create_clients_and_change_column_null'
 
diff --git a/test/cases/coerced_tests.rb b/test/cases/coerced_tests.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 
diff --git a/test/cases/column_test_sqlserver.rb b/test/cases/column_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # encoding: UTF-8
 require 'cases/helper_sqlserver'
 
diff --git a/test/cases/connection_test_sqlserver.rb b/test/cases/connection_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/reply'
 require 'models/topic'
diff --git a/test/cases/execute_procedure_test_sqlserver.rb b/test/cases/execute_procedure_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class ExecuteProcedureTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/fetch_test_sqlserver.rb b/test/cases/fetch_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/book'
 
diff --git a/test/cases/fully_qualified_identifier_test_sqlserver.rb b/test/cases/fully_qualified_identifier_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class FullyQualifiedIdentifierTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/helper_sqlserver.rb b/test/cases/helper_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'support/paths_sqlserver'
 require 'bundler/setup'
 Bundler.require :default, :development
diff --git a/test/cases/in_clause_test_sqlserver.rb b/test/cases/in_clause_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/post'
 require 'models/author'
diff --git a/test/cases/index_test_sqlserver.rb b/test/cases/index_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class IndexTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/json_test_sqlserver.rb b/test/cases/json_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 if ActiveRecord::Base.connection.supports_json?
diff --git a/test/cases/migration_test_sqlserver.rb b/test/cases/migration_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/person'
 
diff --git a/test/cases/order_test_sqlserver.rb b/test/cases/order_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/post'
 
diff --git a/test/cases/pessimistic_locking_test_sqlserver.rb b/test/cases/pessimistic_locking_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/person'
 require 'models/reader'
diff --git a/test/cases/rake_test_sqlserver.rb b/test/cases/rake_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SQLServerRakeTest < ActiveRecord::TestCase
diff --git a/test/cases/schema_dumper_test_sqlserver.rb b/test/cases/schema_dumper_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SchemaDumperTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/schema_test_sqlserver.rb b/test/cases/schema_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SchemaTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/scratchpad_test_sqlserver.rb b/test/cases/scratchpad_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class ScratchpadTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/showplan_test_sqlserver.rb b/test/cases/showplan_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/car'
 
diff --git a/test/cases/specific_schema_test_sqlserver.rb b/test/cases/specific_schema_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/transaction_test_sqlserver.rb b/test/cases/transaction_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # encoding: UTF-8
 require 'cases/helper_sqlserver'
 require 'models/ship'
diff --git a/test/cases/trigger_test_sqlserver.rb b/test/cases/trigger_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # encoding: UTF-8
 require 'cases/helper_sqlserver'
 
diff --git a/test/cases/utils_test_sqlserver.rb b/test/cases/utils_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class UtilsTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/uuid_test_sqlserver.rb b/test/cases/uuid_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # encoding: UTF-8
 require 'cases/helper_sqlserver'
 
diff --git a/test/debug.rb b/test/debug.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # require 'rails/all'
 require 'tiny_tds'
 
diff --git a/test/migrations/create_clients_and_change_column_null.rb b/test/migrations/create_clients_and_change_column_null.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateClientsAndChangeColumnNull < ActiveRecord::Migration[5.2]
   def up
     create_table :clients do |t|
diff --git a/test/migrations/transaction_table/1_table_will_never_be_created.rb b/test/migrations/transaction_table/1_table_will_never_be_created.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TableWillNeverBeCreated < ActiveRecord::Migration
 
   def self.up
diff --git a/test/models/sqlserver/booking.rb b/test/models/sqlserver/booking.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestBooking < ActiveRecord::Base
   self.table_name = 'sst_bookings'
 end
diff --git a/test/models/sqlserver/customers_view.rb b/test/models/sqlserver/customers_view.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestCustomersView < ActiveRecord::Base
   self.table_name = 'sst_customers_view'
 end
diff --git a/test/models/sqlserver/datatype.rb b/test/models/sqlserver/datatype.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDatatype < ActiveRecord::Base
   self.table_name = :sst_datatypes
 end
diff --git a/test/models/sqlserver/datatype_migration.rb b/test/models/sqlserver/datatype_migration.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDatatypeMigration < ActiveRecord::Base
   self.table_name = :sst_datatypes_migration
 end
diff --git a/test/models/sqlserver/dollar_table_name.rb b/test/models/sqlserver/dollar_table_name.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDollarTableName < ActiveRecord::Base
   self.table_name = 'sst_my$strange_table'
 end
diff --git a/test/models/sqlserver/edge_schema.rb b/test/models/sqlserver/edge_schema.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestEdgeSchema < ActiveRecord::Base
 
   self.table_name = 'sst_edge_schemas'
diff --git a/test/models/sqlserver/fk_has_fk.rb b/test/models/sqlserver/fk_has_fk.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestHasFk < ActiveRecord::Base
   self.table_name = 'sst_has_fks'
 end
diff --git a/test/models/sqlserver/fk_has_pk.rb b/test/models/sqlserver/fk_has_pk.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestHasPk < ActiveRecord::Base
   self.table_name = 'sst_has_pks'
 end
diff --git a/test/models/sqlserver/natural_pk_data.rb b/test/models/sqlserver/natural_pk_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNaturalPkData < ActiveRecord::Base
   self.table_name = 'sst_natural_pk_data'
   self.primary_key = 'legacy_id'
diff --git a/test/models/sqlserver/natural_pk_int_data.rb b/test/models/sqlserver/natural_pk_int_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNaturalPkIntData < ActiveRecord::Base
   self.table_name = 'sst_natural_pk_int_data'
 end
diff --git a/test/models/sqlserver/no_pk_data.rb b/test/models/sqlserver/no_pk_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNoPkData < ActiveRecord::Base
   self.table_name = 'sst_no_pk_data'
 end
diff --git a/test/models/sqlserver/object_default.rb b/test/models/sqlserver/object_default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestObjectDefault < ActiveRecord::Base
   self.table_name = 'sst_defaultobjects'
 end
diff --git a/test/models/sqlserver/quoted_table.rb b/test/models/sqlserver/quoted_table.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedTable < ActiveRecord::Base
   self.table_name = '[sst_quoted-table]'
 end
diff --git a/test/models/sqlserver/quoted_view_1.rb b/test/models/sqlserver/quoted_view_1.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedView1 < ActiveRecord::Base
   self.table_name = 'sst_quoted-view1'
 end
diff --git a/test/models/sqlserver/quoted_view_2.rb b/test/models/sqlserver/quoted_view_2.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedView2 < ActiveRecord::Base
   self.table_name = 'sst_quoted-view2'
 end
diff --git a/test/models/sqlserver/sst_memory.rb b/test/models/sqlserver/sst_memory.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTMemory < ActiveRecord::Base
   self.table_name = 'sst_memory'
 end
diff --git a/test/models/sqlserver/string_default.rb b/test/models/sqlserver/string_default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefault < ActiveRecord::Base
   self.table_name = 'sst_string_defaults'
 end
diff --git a/test/models/sqlserver/string_defaults_big_view.rb b/test/models/sqlserver/string_defaults_big_view.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefaultsBigView < ActiveRecord::Base
   self.table_name = 'sst_string_defaults_big_view'
 end
diff --git a/test/models/sqlserver/string_defaults_view.rb b/test/models/sqlserver/string_defaults_view.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefaultsView < ActiveRecord::Base
   self.table_name = 'sst_string_defaults_view'
 end
diff --git a/test/models/sqlserver/tinyint_pk.rb b/test/models/sqlserver/tinyint_pk.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTinyintPk < ActiveRecord::Base
   self.table_name = 'sst_tinyint_pk'
 end
diff --git a/test/models/sqlserver/trigger.rb b/test/models/sqlserver/trigger.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTrigger < ActiveRecord::Base
   self.table_name = 'sst_table_with_trigger'
 end
diff --git a/test/models/sqlserver/trigger_history.rb b/test/models/sqlserver/trigger_history.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTriggerHistory < ActiveRecord::Base
   self.table_name = 'sst_table_with_trigger_history'
 end
diff --git a/test/models/sqlserver/upper.rb b/test/models/sqlserver/upper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUpper < ActiveRecord::Base
   self.table_name = 'sst_upper_tests'
 end
diff --git a/test/models/sqlserver/uppered.rb b/test/models/sqlserver/uppered.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUppered < ActiveRecord::Base
   self.table_name = 'SST_UPPER_TESTS'
 end
diff --git a/test/models/sqlserver/uuid.rb b/test/models/sqlserver/uuid.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUuid < ActiveRecord::Base
   self.table_name = 'sst_uuids'
 end
diff --git a/test/schema/sqlserver_specific_schema.rb b/test/schema/sqlserver_specific_schema.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ActiveRecord::Schema.define do
 
   # Exhaustive Data Types
diff --git a/test/support/coerceable_test_sqlserver.rb b/test/support/coerceable_test_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
     module CoerceableTest
diff --git a/test/support/connection_reflection.rb b/test/support/connection_reflection.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
     module ConnectionReflection
diff --git a/test/support/core_ext/query_cache.rb b/test/support/core_ext/query_cache.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/connection_adapters/sqlserver_adapter'
 
 module SqlIgnoredCache
diff --git a/test/support/load_schema_sqlserver.rb b/test/support/load_schema_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
 
diff --git a/test/support/minitest_sqlserver.rb b/test/support/minitest_sqlserver.rb
@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'minitest-spec-rails/init/active_support'
diff --git a/test/support/paths_sqlserver.rb b/test/support/paths_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
 
diff --git a/test/support/rake_helpers.rb b/test/support/rake_helpers.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 SQLSERVER_HELPER = 'test/cases/helper_sqlserver.rb'
 SQLSERVER_COERCED = 'test/cases/coerced_tests.rb'
diff --git a/test/support/sql_counter_sqlserver.rb b/test/support/sql_counter_sqlserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
 
diff --git a/test/support/test_in_memory_oltp.rb b/test/support/test_in_memory_oltp.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV['IN_MEMORY_OLTP']
   require 'config'
   require 'active_record'

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'cases/helper_sqlserver'`
`2`	`4`	`require 'models/topic'`
`3`	`5`	`require 'models/task'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# encoding: UTF-8`
`2`	`4`	`require 'cases/helper_sqlserver'`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'support/paths_sqlserver'`
`2`	`4`	`require 'bundler/setup'`
`3`	`5`	`Bundler.require :default, :development`