-
Notifications
You must be signed in to change notification settings - Fork 96
caches_action with layout: false produces escaped html output on uncached response #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this PR #42 fix it |
Bitten by this. Any chance for this being merged? |
I've too had this issue... but secondly, I am getting my layout inside my layout... My guess was that the originally the page + layout was cached so ran I believe this was also raised (but misunderstood) by @vishaljagtap-tudip in his comment in #47. @jonn @jogaco @nazarok @antulik Have you experienced this issue? |
Don't remember if I had layout inside layout. I do remember escaped html output. I am now using @antulik fork which solves the problem |
@jogaco Thanks, tried using the fork, no luck. |
Just checked. This produces an escaped html output. |
also checked and @antulik fork fixes the problem for me. |
Ran into this and #42 works for us. |
@rafaelfranca any chance of getting this merged and a new release out please? |
Fix #43 html escaping when layout is false
As of actionpack-action_caching 1.2.0, I’m getting escaped HTML for the output of a
caches_action
action when there is no cache to serve. When the action is already cached, the HTML output is not escaped and pages look/function as expected.Reverting to actionpack-action_caching 1.1.1 restores the expected behavior (html not escaped whether action output is cached or not).
The text was updated successfully, but these errors were encountered: