Skip to content

Commit 640b538

Browse files
committed
Fix leaky test
This test was changing the user of Person and affecting other tests. We need to reset the user after the test has run.
1 parent a0ddb80 commit 640b538

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ gem "rubocop-packaging"
1515
gem "rubocop-performance"
1616
gem "rubocop-rails"
1717

18+
gem "minitest-bisect"
19+
1820
gemspec
1921

2022
platform :mri do

test/cases/base_test.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@ def test_user_reader_uses_superclass_user_until_written
306306
# Superclass is Object so returns nil.
307307
assert_nil ActiveResource::Base.user
308308
assert_nil Class.new(ActiveResource::Base).user
309+
person_user = Person.user
309310
Person.user = "anonymous".dup
310311

311312
# Subclass uses superclass user.
@@ -338,6 +339,8 @@ def test_user_reader_uses_superclass_user_until_written
338339

339340
fruit.user = "client"
340341
assert_equal fruit.user, apple.user, "subclass did not adopt changes from parent class"
342+
ensure
343+
Person.user = person_user
341344
end
342345

343346
def test_password_reader_uses_superclass_password_until_written

0 commit comments

Comments
 (0)