Skip to content

Commit 6aedd90

Browse files
committed
catch failure HTTP responses on calls to the npm registry & add a more descriptive error message
1 parent d91d5e1 commit 6aedd90

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

lib/importmap/npm.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,10 @@ def get_json(uri)
8080
http.request(request)
8181
}
8282

83+
unless response.kind_of? Net::HTTPSuccess
84+
raise HTTPError, "Unexpected error response #{response.code}: #{response.body}"
85+
end
86+
8387
response.body
8488
rescue => error
8589
raise HTTPError, "Unexpected transport error (#{error.class}: #{error.message})"
@@ -111,6 +115,9 @@ def get_audit
111115
return {} if body.empty?
112116

113117
response = post_json(uri, body)
118+
unless response.kind_of? Net::HTTPSuccess
119+
raise HTTPError, "Unexpected error response #{response.code}: #{response.body}"
120+
end
114121
JSON.parse(response.body)
115122
end
116123

0 commit comments

Comments
 (0)