moves a hard-coded rule to a false positive

While having this exception as a hard-coded rule yields the correct credit,
as a rule of thumb that is a last resort, generally for the use case in
which Git does not even have the information about the author.

When the author can be extracted, but the square brackets heuristic gives
a false positive, we discard the false positive and let the rest of the
logic do its thing.

Author: fxn

app/models/names_manager/false_positives.rb

@@ -39,6 +39,7 @@ def handle_false_positives(name)
         when "{ :ca => :'es-ES' }"
         when 'fixes 5f5e6d924973003c105feb711cefdb726f312768'
         when '79990505e5080804b53d81fec059136afa2237d7'
+        when 'direct_upload_xls_in_chrome'
         when "schoenm\100earthlink.net sandra.metz\100duke.edu"
           name.split
         when '=?utf-8?q?Adam=20Cig=C3=A1nek?='

app/models/names_manager/hard_coded_authors.rb

@@ -90,10 +90,6 @@ def hard_coded_authors(commit)
       when '9668cc3bb03740b13477df0832332eec71563bc5'
         # Backport of the above commit.
         ['Eileen M. Uchitelle', 'Aaron Patterson', 'Tsukuru Tanimichi']
-      when '1d133e8a4725439e4a61d53ce913eba9dcab42d3'
-        # This attribution was incorrectly given to "direct_upload_xls_in_chrome",
-        # (the branch name) which was included in the commit messages in brackets.
-        ['Nick Weiland']
       else
         nil
       end

test/credits/false_positives_test.rb

@@ -165,6 +165,10 @@ class FalsePositivesTest < ActiveSupport::TestCase
       assert_contributor_names 'eade591', 'Prem Sichanugrist'
     end
 
+    test 'direct_upload_xls_in_chrome' do
+      assert_contributor_names '1d133e8', 'Nick Weiland'
+    end
+
     test "schoenm\100earthlink.net sandra.metz\100duke.edu" do
       assert_contributor_names '242cd06', 'Michael Schoen', 'Sandi Metz'
     end

test/credits/hard_coded_authors_test.rb

@@ -31,7 +31,6 @@ class SpecialCasedCommitsTest < ActiveSupport::TestCase
       assert_contributor_names '872e22c', 'Daniel Rikowski', 'Genadi Samokovarov'
       assert_contributor_names '9220935', 'Eileen M. Uchitelle', 'Aaron Patterson', 'Tsukuru Tanimichi'
       assert_contributor_names '9668cc3', 'Eileen M. Uchitelle', 'Aaron Patterson', 'Tsukuru Tanimichi'
-      assert_contributor_names '1d133e8', 'Nick Weiland'
     end
   end
 end