From 5f4c8358460521429553cc3aa9027898929e1d8d Mon Sep 17 00:00:00 2001 From: "JC (Jonathan Chen)" Date: Thu, 6 Feb 2025 14:55:34 -0500 Subject: [PATCH 1/2] fix: add JC canonical name --- app/models/names_manager/canonical_names.rb | 1 + test/credits/canonical_names_test.rb | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/app/models/names_manager/canonical_names.rb b/app/models/names_manager/canonical_names.rb index cec14877..1438abb9 100644 --- a/app/models/names_manager/canonical_names.rb +++ b/app/models/names_manager/canonical_names.rb @@ -554,6 +554,7 @@ def self.map(canonical_name, *also_as) map 'Jason Stirk', "jstirk\100oobleyboo.com" map 'Javier Ramírez', 'jramirez' map 'Jay Levitt', "jay\100jay.fm" + map 'JC (Jonathan Chen)' 'Jonathan Chen' map 'Jean Baptiste Barth', 'jbbarth' map 'Jean Boussier', 'Jean byroot Boussier' map 'Jean Helou', "jean.helou\100gmail.com", 'jean.helou' diff --git a/test/credits/canonical_names_test.rb b/test/credits/canonical_names_test.rb index 14a708c2..16657fdb 100644 --- a/test/credits/canonical_names_test.rb +++ b/test/credits/canonical_names_test.rb @@ -2263,6 +2263,10 @@ class CanonicalNamesTest < ActiveSupport::TestCase assert_contributor_names '4d9ca4d', 'Jon Bright' end + test "Jonathan Chen" do + assert_contributor_names '58b4448', 'JC (Jonathan Chen)' + end + test "jonathan\100bluewire.net.nz" do assert_contributor_names '1aff68d', 'Jonathan Viney' end From 13a55f9a8bab859367390ecc5c4e815593a5b475 Mon Sep 17 00:00:00 2001 From: "JC (Jonathan Chen)" Date: Fri, 7 Feb 2025 16:15:57 -0500 Subject: [PATCH 2/2] fix: add missing comma --- app/models/names_manager/canonical_names.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/names_manager/canonical_names.rb b/app/models/names_manager/canonical_names.rb index 1438abb9..5a4c9858 100644 --- a/app/models/names_manager/canonical_names.rb +++ b/app/models/names_manager/canonical_names.rb @@ -554,7 +554,7 @@ def self.map(canonical_name, *also_as) map 'Jason Stirk', "jstirk\100oobleyboo.com" map 'Javier Ramírez', 'jramirez' map 'Jay Levitt', "jay\100jay.fm" - map 'JC (Jonathan Chen)' 'Jonathan Chen' + map 'JC (Jonathan Chen)', 'Jonathan Chen' map 'Jean Baptiste Barth', 'jbbarth' map 'Jean Boussier', 'Jean byroot Boussier' map 'Jean Helou', "jean.helou\100gmail.com", 'jean.helou'