Skip to content

sameHost check with https: urls #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
finchi opened this issue Oct 2, 2024 · 5 comments · Fixed by #81
Closed

sameHost check with https: urls #80

finchi opened this issue Oct 2, 2024 · 5 comments · Fixed by #81

Comments

@finchi
Copy link

finchi commented Oct 2, 2024

Hello,

I encountered an issue with a CDN that blocked the x-csrf-token header. Since the CDN and the requesting site have different hostnames, I was initially confused about where the problem was originating.

After reviewing the code, I found the following line and was wondering why https: is not included here:

if (!this.originalUrl.startsWith('http:')) {

Is this an oversight, or is there another reason for omitting https:?

@marcelolx
Copy link
Collaborator

Probably an oversight @t27duck?

Related PR #46

@t27duck
Copy link
Contributor

t27duck commented Oct 3, 2024

Yep, probably an oversight. I'll see if I can get a PR going shortly. If I can't (at my day job right now) it'll be later this evening.

@t27duck
Copy link
Contributor

t27duck commented Oct 3, 2024

#81 should do it

@marcelolx
Copy link
Collaborator

Thanks @t27duck

@finchi
Copy link
Author

finchi commented Oct 3, 2024

@t27duck thanks for the quick fix 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants