Skip to content

Commit 9ce433b

Browse files
committed
Follow importmap-rails recomendations for engines
1 parent 411b324 commit 9ce433b

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

config/importmap.rb

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
pin "@rails/request.js", to: "requestjs.js"

lib/install/requestjs_with_asset_pipeline.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
create_file Rails.root.join("app/javascript/application.js") unless APP_JS_PATH.exist?
55

66
say "Import Request.JS in existing #{APP_JS_PATH}"
7-
append_to_file APP_JS_PATH.join("application.js"), %(import "@rails/requestjs"\n)
7+
append_to_file APP_JS_PATH.join("application.js"), %(import "@rails/request.js"\n)

lib/requestjs/engine.rb

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,8 @@ class Engine < ::Rails::Engine
66
end
77
end
88

9-
initializer "requestjs.importmap" do
10-
if Rails.application.respond_to?(:importmap)
11-
Rails.application.importmap.draw do
12-
pin "@rails/requestjs", to: "requestjs.js"
13-
end
14-
end
9+
initializer "requestjs.importmap", before: "importmap" do |app|
10+
app.config.importmap.paths << Engine.root.join("config/importmap.rb")
1511
end
1612
end
1713
end

0 commit comments

Comments
 (0)