Refactor slightly how executions assume attributes from job

Just to test how it feels to do it in this way.

Author: rosa

app/models/solid_queue/blocked_execution.rb

@@ -1,10 +1,3 @@
 class SolidQueue::BlockedExecution < SolidQueue::Execution
-  before_create :assume_attributes_from_job
-
-  private
-    def assume_attributes_from_job
-      super
-      self.concurrency_limit ||= job.concurrency_limit
-      self.concurrency_key   ||= job.concurrency_key
-    end
+  assume_attributes_from_job :concurrency_limit, :concurrency_key
 end

app/models/solid_queue/execution.rb

@@ -1,13 +1,9 @@
 class SolidQueue::Execution < SolidQueue::Record
+  include JobAttributes
+
   self.abstract_class = true
 
   belongs_to :job
 
   alias_method :discard, :destroy
-
-  private
-    def assume_attributes_from_job
-      self.queue_name ||= job&.queue_name
-      self.priority = job&.priority if job&.priority.to_i > priority
-    end
 end

app/models/solid_queue/execution/job_attributes.rb

@@ -0,0 +1,22 @@
+module SolidQueue
+  class Execution
+    module JobAttributes
+      extend ActiveSupport::Concern
+
+      ASSUMIBLE_ATTRIBUTES_FROM_JOB = %i[ queue_name priority ]
+
+      class_methods do
+        def assume_attributes_from_job(*attributes)
+          before_create -> { assume_attributes_from_job(ASSUMIBLE_ATTRIBUTES_FROM_JOB | attributes) }
+        end
+      end
+
+      private
+        def assume_attributes_from_job(attributes)
+          attributes.each do |attribute|
+            send("#{attribute}=", job.send(attribute))
+          end
+        end
+    end
+  end
+end

app/models/solid_queue/ready_execution.rb

@@ -3,7 +3,7 @@ class ReadyExecution < Execution
     scope :ordered, -> { order(priority: :asc) }
     scope :not_paused, -> { where.not(queue_name: Pause.all_queue_names) }
 
-    before_create :assume_attributes_from_job
+    assume_attributes_from_job
 
     class << self
       def claim(queues, limit, process_id)

app/models/solid_queue/scheduled_execution.rb

@@ -3,7 +3,7 @@ class SolidQueue::ScheduledExecution < SolidQueue::Execution
   scope :ordered, -> { order(scheduled_at: :asc, priority: :asc) }
   scope :next_batch, ->(batch_size) { due.ordered.limit(batch_size) }
 
-  before_create :assume_attributes_from_job
+  assume_attributes_from_job :scheduled_at
 
   class << self
     def prepare_batch(batch)
@@ -27,10 +27,4 @@ def prepare_batch(batch)
   def execution_ready_attributes
     attributes.slice("job_id", "queue_name", "priority")
   end
-
-  private
-    def assume_attributes_from_job
-      super
-      self.scheduled_at ||= job&.scheduled_at
-    end
 end