Reorder scheduled execution code a bit

Author: rosa

app/models/solid_queue/scheduled_execution.rb

@@ -15,18 +15,26 @@ def prepare_next_batch(batch_size)
 
     private
       def prepare_batch(batch)
-        prepared_at = Time.current
+        if batch.empty? then []
+        else
+          promote_batch_to_ready(batch)
+        end
+      end
 
-        rows = batch.map do |scheduled_execution|
-          scheduled_execution.ready_attributes.merge(created_at: prepared_at)
+      def promote_batch_to_ready(batch)
+        rows = ready_rows_from_batch(batch)
+
+        SolidQueue::ReadyExecution.insert_all(rows)
+        SolidQueue::ReadyExecution.where(job_id: batch.map(&:job_id)).pluck(:job_id).tap do |enqueued_job_ids|
+          where(job_id: enqueued_job_ids).delete_all
         end
+      end
 
-        if rows.empty? then []
-        else
-          SolidQueue::ReadyExecution.insert_all(rows)
-          SolidQueue::ReadyExecution.where(job_id: batch.map(&:job_id)).pluck(:job_id).tap do |enqueued_job_ids|
-            where(job_id: enqueued_job_ids).delete_all
-          end
+      def ready_rows_from_batch(batch)
+        prepared_at = Time.current
+
+        batch.map do |scheduled_execution|
+          scheduled_execution.ready_attributes.merge(created_at: prepared_at)
         end
       end
   end