Refactor a bit how next batch of scheduled executions is selected

For clarity.

Author: rosa

app/models/solid_queue/scheduled_execution.rb

@@ -8,8 +8,8 @@ class SolidQueue::ScheduledExecution < SolidQueue::Execution
   class << self
     def prepare_next_batch(batch_size)
       transaction do
-        prepared_job_ids = prepare_batch next_batch(batch_size).lock("FOR UPDATE SKIP LOCKED").tap(&:load)
-        prepared_job_ids.present?
+        batch = next_batch(batch_size).lock("FOR UPDATE SKIP LOCKED").tap(&:load)
+        prepare_batch batch
       end
     end
 

lib/solid_queue/scheduler.rb

@@ -19,15 +19,15 @@ def initialize(**options)
 
     private
       def run
-        with_polling_volume do
-          unless select_and_prepare_next_batch
-            procline "waiting"
-            interruptible_sleep(polling_interval)
-          end
+        batch = prepare_next_batch
+
+        unless batch.size > 0
+          procline "waiting"
+          interruptible_sleep(polling_interval)
         end
       end
 
-      def select_and_prepare_next_batch
+      def prepare_next_batch
         with_polling_volume do
           SolidQueue::ScheduledExecution.prepare_next_batch(batch_size)
         end