From f06cd9ae4b5c018181a12ca3c3e24567cbc292f1 Mon Sep 17 00:00:00 2001 From: Rosa Gutierrez Date: Tue, 28 Jan 2025 09:47:57 +0100 Subject: [PATCH] Address Ruby 3.4 frozen string warnings and improve flaky test --- test/integration/processes_lifecycle_test.rb | 4 +++- test/models/solid_queue/process_test.rb | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/integration/processes_lifecycle_test.rb b/test/integration/processes_lifecycle_test.rb index b96c452d..3d15283a 100644 --- a/test/integration/processes_lifecycle_test.rb +++ b/test/integration/processes_lifecycle_test.rb @@ -121,7 +121,9 @@ class ProcessesLifecycleTest < ActiveSupport::TestCase no_pause = enqueue_store_result_job("no pause") pause = enqueue_store_result_job("pause", pause: SolidQueue.shutdown_timeout + 10.second) - signal_process(@pid, :TERM, wait: 0.5.second) + wait_while_with_timeout(1.second) { SolidQueue::ReadyExecution.count > 0 } + + signal_process(@pid, :TERM, wait: 0.5) sleep(SolidQueue.shutdown_timeout + 0.5.second) diff --git a/test/models/solid_queue/process_test.rb b/test/models/solid_queue/process_test.rb index 5504f0e6..489b2aca 100644 --- a/test/models/solid_queue/process_test.rb +++ b/test/models/solid_queue/process_test.rb @@ -60,7 +60,7 @@ class SolidQueue::ProcessTest < ActiveSupport::TestCase worker = SolidQueue::Worker.new(queues: "*", threads: 3, polling_interval: 0.2) hostname = "Basecamp’s-Computer" - Socket.stub :gethostname, hostname.force_encoding("ASCII-8BIT") do + Socket.stub :gethostname, hostname.dup.force_encoding("ASCII-8BIT") do worker.start wait_for_registered_processes(1, timeout: 1.second)