Skip to content

Commit de5eacf

Browse files
committed
Update the CI matrix and fix test suite on Rails 7.1
1 parent 1399046 commit de5eacf

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

.github/workflows/ci.yml

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,11 @@ jobs:
66
strategy:
77
fail-fast: false
88
matrix:
9-
ruby: [ '2.7', '3.0.2', '3.1', '3.2', 'head' ]
10-
rails: [ '6.0', '6.1', '7.0', 'edge' ]
9+
ruby: [ '2.7', '3.0', '3.1', '3.2', 'head' ]
10+
rails: [ '6.1', '7.0', '7.1', 'edge' ]
1111
exclude:
12-
- ruby: '3.1'
13-
rails: '6.0'
1412
- ruby: '3.1'
1513
rails: '6.1'
16-
- ruby: '3.2'
17-
rails: '6.0'
1814
- ruby: '3.2'
1915
rails: '6.1'
2016

Gemfile

-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ gemspec
55

66
if ENV["RAILS_VERSION"] == "edge"
77
gem "activesupport", github: "rails/rails", branch: "main"
8-
elsif ENV['RAILS_VERSION'] == "7.0"
9-
gem "activesupport", ">= 7.0.0.alpha"
108
elsif ENV["RAILS_VERSION"]
119
gem "activesupport", "~> #{ENV["RAILS_VERSION"]}.0"
1210
end

test/support/acceptance_test.rb

+6-2
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,11 @@ def without_gem(name)
139139
test "raises if config.cache_classes is true" do
140140
config_path = app.path("config/environments/development.rb")
141141
config = File.read(config_path)
142-
config.sub!(/config.cache_classes\s*=\s*false/, "config.cache_classes = true")
142+
if config.include?("config.cache_classes")
143+
config.sub!(/config\.cache_classes\s*=\s*false/, "config.cache_classes = true")
144+
else # 7.1+ doesn't have config.cache_classes in the config at all
145+
config.sub!(/config.enable_reloading = true/, "config.enable_reloading = true\nconfig.cache_classes = true")
146+
end
143147
File.write(config_path, config)
144148

145149
assert_failure "bin/rails runner 1", stderr: "Please, set config.cache_classes to false"
@@ -258,7 +262,7 @@ def exec_name
258262
end
259263

260264
test "binstub" do
261-
assert_success "bin/rails server --help", stdout: /Usage:\s+rails server/ # rails command fallback
265+
assert_success "bin/rails server --help", stdout: /Usage:\s+(bin\/)?rails server/ # rails command fallback
262266

263267
assert_success "#{app.spring} binstub rake", stdout: "bin/rake: Spring already present"
264268

test/support/application_generator.rb

+5-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,11 @@ def generate_files
6464
end
6565

6666
rewrite_file(application.path("config/environments/test.rb")) do |c|
67-
c.sub!(/config\.cache_classes\s*=\s*true/, "config.cache_classes = false")
67+
if c.include?("config.cache_classes")
68+
c.sub!(/config\.cache_classes\s*=\s*true/, "config.cache_classes = false")
69+
else # 7.1+ doesn't have config.cache_classes in the config at all
70+
c.sub!(/config.enable_reloading = false/, "config.enable_reloading = false\nconfig.cache_classes = false")
71+
end
6872
c
6973
end
7074

0 commit comments

Comments
 (0)