Skip to content

Commit 38e7743

Browse files
committed
Updated failing tests to use a new approach
1 parent a29a750 commit 38e7743

File tree

7 files changed

+45
-60
lines changed

7 files changed

+45
-60
lines changed

src/test/java/io/mailtrap/api/AttachmentsImplTest.java

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,11 @@ class AttachmentsImplTest extends BaseTest {
2222
@BeforeEach
2323
public void init() {
2424
TestHttpClient httpClient = new TestHttpClient(List.of(
25-
DataMock.build(
26-
Constants.GENERAL_HOST + "/api/accounts/" + accountId + "/inboxes/" + inboxId + "/messages/" + messageId + "/attachments",
27-
"GET",
28-
null,
29-
"api/attachments/getAttachmentsResponse.json"
30-
),
31-
DataMock.build(
32-
Constants.GENERAL_HOST + "/api/accounts/" + accountId + "/inboxes/" + inboxId + "/messages/" + messageId + "/attachments/" + attachmentId,
33-
"GET",
34-
null,
35-
"api/attachments/getAttachmentResponse.json"
36-
)
25+
DataMock.build(Constants.GENERAL_HOST + "/api/accounts/" + accountId + "/inboxes/" + inboxId + "/messages/" + messageId + "/attachments",
26+
"GET", null, "api/attachments/getAttachmentsResponse.json"),
27+
28+
DataMock.build(Constants.GENERAL_HOST + "/api/accounts/" + accountId + "/inboxes/" + inboxId + "/messages/" + messageId + "/attachments/" + attachmentId,
29+
"GET", null, "api/attachments/getAttachmentResponse.json")
3730
));
3831

3932
MailtrapConfig testConfig = new MailtrapConfig.Builder()

src/test/java/io/mailtrap/api/BulkEmailsImplTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,8 @@ public void init() {
2626
DataMock.build(
2727
Constants.BULK_SENDING_HOST + "/api/send",
2828
"POST",
29-
createValidTestMail().toJson(),
30-
"""
31-
{
32-
"success": true,
33-
"message_ids": ["11111"]
34-
}"""
29+
"api/emails/sendRequest.json",
30+
"api/emails/sendResponse.json"
3531
)
3632
));
3733

src/test/java/io/mailtrap/api/SendingEmailsImplTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,8 @@ public void init() {
2727
DataMock.build(
2828
Constants.EMAIL_SENDING_SEND_HOST + "/api/send",
2929
"POST",
30-
createValidTestMail().toJson(),
31-
"""
32-
{
33-
"success": true,
34-
"message_ids": ["11111"]
35-
}"""
30+
"api/emails/sendRequest.json",
31+
"api/emails/sendResponse.json"
3632
)
3733
));
3834

src/test/java/io/mailtrap/api/TestingEmailsImplTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,8 @@ public void init() {
2727
DataMock.build(
2828
Constants.EMAIL_TESTING_SEND_HOST + "/api/send/" + INBOX_ID,
2929
"POST",
30-
createValidTestMail().toJson(),
31-
"""
32-
{
33-
"success": true,
34-
"message_ids": ["11111"]
35-
}"""
30+
"api/emails/sendRequest.json",
31+
"api/emails/sendResponse.json"
3632
)
3733
));
3834

src/test/java/io/mailtrap/client/MailtrapClientTest.java

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -24,36 +24,14 @@ class MailtrapClientTest extends BaseSendTest {
2424
@BeforeEach
2525
void setUp() {
2626
TestHttpClient httpClient = new TestHttpClient(List.of(
27-
DataMock.build(
28-
Constants.EMAIL_TESTING_SEND_HOST + "/api/send/" + INBOX_ID,
29-
"POST",
30-
createValidTestMail().toJson(),
31-
"""
32-
{
33-
"success": true,
34-
"message_ids": ["11111"]
35-
}"""
36-
),
37-
DataMock.build(
38-
Constants.BULK_SENDING_HOST + "/api/send",
39-
"POST",
40-
createValidTestMail().toJson(),
41-
"""
42-
{
43-
"success": true,
44-
"message_ids": ["11111"]
45-
}"""
46-
),
47-
DataMock.build(
48-
Constants.EMAIL_SENDING_SEND_HOST + "/api/send",
49-
"POST",
50-
createValidTestMail().toJson(),
51-
"""
52-
{
53-
"success": true,
54-
"message_ids": ["11111"]
55-
}"""
56-
)
27+
DataMock.build(Constants.EMAIL_TESTING_SEND_HOST + "/api/send/" + INBOX_ID, "POST",
28+
"api/emails/sendRequest.json", "api/emails/sendResponse.json"),
29+
30+
DataMock.build(Constants.BULK_SENDING_HOST + "/api/send", "POST",
31+
"api/emails/sendRequest.json", "api/emails/sendResponse.json"),
32+
33+
DataMock.build(Constants.EMAIL_SENDING_SEND_HOST + "/api/send", "POST",
34+
"api/emails/sendRequest.json", "api/emails/sendResponse.json")
5735
));
5836

5937
MailtrapConfig mailtrapConfig = new MailtrapConfig.Builder()
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
{
2+
"from": {
3+
"name": "John Doe",
4+
"email": "[email protected]"
5+
},
6+
"to": [
7+
{
8+
"name": "Jane Doe",
9+
"email": "[email protected]"
10+
}
11+
],
12+
"attachments": [
13+
{
14+
"content": "c2FtcGxlIHRleHQgaW4gdGV4dCBmaWxl",
15+
"type": "text/plain",
16+
"filename": "attachment.txt"
17+
}
18+
],
19+
"subject": "Sample valid mail subject",
20+
"text": "Sample valid mail text",
21+
"html": "<html><body>Test HTML</body></html>"
22+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"success": true,
3+
"message_ids": ["11111"]
4+
}

0 commit comments

Comments
 (0)