get_pbp() function no longer working?

[ahmed-cheema]

I was using this tutorial when I got stuck due to the get_pbp part not working for me. I posted to StackOverflow for help and figured out that I needed to download the JSON file first and then convert it because stats.nba.com doesn't allow it to connect.

So instead of this:

get_pbp <- function(gameid){
  #Grabs the play by play data from the NBA site
  URL1 <- paste("http://stats.nba.com/stats/playbyplayv2?EndPeriod=10&EndRange=55800&GameID=",gameid,"&RangeType=2&StartPeriod=1&StartRange=0",sep = "")
  the.data.file<-fromJSON(URL1)
  test <-the.data.file$resultSets$rowSet
  test2 <- test[[1]]
  test3 <- data.frame(test2)
  coltest <- the.data.file$resultSets$headers
  colnames(test3) <- coltest[[1]]
  return (test3)}

I altered it to this:

get_pbp <- function(gameid){
  #Grabs the play by play data from the NBA site
  URL1 <- paste("http://stats.nba.com/stats/playbyplayv2?EndPeriod=10&EndRange=55800&GameID=",gameid,"&RangeType=2&StartPeriod=1&StartRange=0",sep = "")
  curl_download(URL1, "nba.json")
  the.data.file<-fromJSON("nba.json")
  test <-the.data.file$resultSets$rowSet
  test2 <- test[[1]]
  test3 <- data.frame(test2)
  coltest <- the.data.file$resultSets$headers
  colnames(test3) <- coltest[[1]]
  return (test3)
  }

and it worked.

You probably have a better fix, but I just wanted to let you know that it appears to need an adjustment.

Thanks

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.55. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.