Adds test for update and findone

Author: ramiel

lib/sequence.js

@@ -175,25 +175,24 @@ Sequence.prototype._setHooks = function() {
 
         // jscs:enable
 
-        this._update['$setOnInsert'] = this._update['$setOnInsert'] || {};
-
         this.model.findOne(_thisquery._conditions, function(err, obj) {
             if (err) return next();
             if (obj) return next();
             else {
                 referenceValue = _this._getCounterReferenceField(_thisquery._update['$setOnInsert']);
                 _this._setNextCounter(_this._options.reference_fields, referenceValue, function(err, seq) {
                     if (err) return next();
+                    _thisquery._update['$setOnInsert'] = _thisquery._update['$setOnInsert'] || {};
                     _thisquery._update['$setOnInsert'][_this._options.inc_field] = seq;
                     next();
                 });
             }
         });
     });
 
-    this._schema.post('findOneAndUpdate', function(next) {
-      // console.dir(this);
-    });
+    // this._schema.post('findOneAndUpdate', function(next) {
+    //     console.dir(this);
+    // });
 
     this._schema.pre('update', function(next, done) {
         // jscs:disable
@@ -202,7 +201,6 @@ Sequence.prototype._setHooks = function() {
 
         // jscs:enable
 
-        this._update['$setOnInsert'] = this._update['$setOnInsert'] || {};
 
         this.model.findOne(_thisquery._conditions, function(err, obj) {
             if (err) return next();
@@ -211,6 +209,7 @@ Sequence.prototype._setHooks = function() {
                 referenceValue = _this._getCounterReferenceField(_thisquery._update['$setOnInsert']);
                 _this._setNextCounter(_this._options.reference_fields, referenceValue, function(err, seq) {
                     if (err) return next();
+                    _thisquery._update['$setOnInsert'] = _thisquery._update['$setOnInsert'] || {};
                     _thisquery._update['$setOnInsert'][_this._options.inc_field] = seq;
                     next();
                 });

package.json

@@ -36,7 +36,8 @@
     "grunt-mocha-cov": "^0.4.0",
     "load-grunt-tasks": "^3.4.1",
     "mocha": "^2.3.3",
-    "mongoose": "^4.1.11"
+    "mongoose": "^4.1.11",
+    "sinon": "^1.17.5"
   },
   "config": {
     "blanket": {

test/base.js

@@ -4,7 +4,8 @@ var chai = require('chai'),
     async = require('async'),
     mongoose = require('mongoose'),
     Schema = mongoose.Schema,
-    AutoIncrement = require('../index');
+    AutoIncrement = require('../index'),
+    sinon = require('sinon');
 
 describe('Basic => ', function() {
 
@@ -191,6 +192,76 @@ describe('Basic => ', function() {
 
         });
 
+        describe('hook', function(){
+            before(function(done) {
+                var SimpleFieldSchema = new Schema({
+                    id: Number,
+                    val: String,
+                    tag: String
+                });
+                var wrapper = function(schema, options) {
+                    var instance = AutoIncrement(schema, options);
+                    this.setNextCounterSpy = sinon.spy(instance, '_setNextCounter');
+                    return instance;
+                }.bind(this);
+                SimpleFieldSchema.plugin(wrapper, {id: 'id_hook_test', inc_field: 'id'});
+                this.SimpleField = mongoose.model('SimpleFieldHookTest', SimpleFieldSchema);
+                this.SimpleField.create({val: 'existing'}, function(err){
+                    this.setNextCounterSpy.reset();
+                    done(err);
+                }.bind(this));
+            });
+
+            afterEach(function(){
+                this.setNextCounterSpy.reset();
+            });
+
+            it('is called when saving a new document', function(done){
+                var t = new this.SimpleField({val: 'a'});
+                t.save(function(err){
+                    sinon.assert.calledOnce(this.setNextCounterSpy);
+                    done(err);
+                }.bind(this));
+            });
+
+            it('is not called when saving an existing document', function(done){
+                var t = new this.SimpleField({val: 'a'});
+                t.isNew = false;
+                t.save(function(err){
+                    sinon.assert.notCalled(this.setNextCounterSpy);
+                    done(err);
+                }.bind(this));
+            });
+
+            it('is called when upserting in an update and result in an insert', function(done){
+                this.SimpleField.update({val: '1234'}, {tag: 'nothing'}, {upsert: true}, function(err, doc){
+                    sinon.assert.calledOnce(this.setNextCounterSpy);
+                    done(err);
+                }.bind(this));
+            });
+
+            it('is not called when upserting in an update and not result in an insert', function(done){
+                this.SimpleField.update({val: 'existing'}, {tag: 'update'}, {upsert: true}, function(err, doc){
+                    sinon.assert.notCalled(this.setNextCounterSpy);
+                    done(err);
+                }.bind(this));
+            });
+
+            it('is called when upserting in an findOneAndUpdate and result in an insert', function(done){
+                this.SimpleField.findOneAndUpdate({val: '4567'}, {tag: 'nothing'}, {upsert: true}, function(err, doc){
+                    sinon.assert.calledOnce(this.setNextCounterSpy);
+                    done(err);
+                }.bind(this));
+            });
+
+            it('is not called when upserting in an findOneAndUpdate and not result in an insert', function(done){
+                this.SimpleField.findOneAndUpdate({val: '1234'}, {tag: 'findOneAndUpdate'}, {upsert: true}, function(err, doc){
+                    sinon.assert.notCalled(this.setNextCounterSpy);
+                    done(err);
+                }.bind(this));
+            });
+        });
+
         describe('a manual increment field => ', function() {
 
             before(function(done) {
@@ -305,7 +376,7 @@ describe('Basic => ', function() {
                     assert.throws(function(){
                         UnusedSchema.plugin(AutoIncrement, {inc_field: 'inhabitant', reference_fields: ['country', 'city'], disable_hooks: true});
                     }, Error);
-                    
+
                 });
             });
 
@@ -342,7 +413,7 @@ describe('Basic => ', function() {
 
             });
 
-        });        
+        });
 
     });
 });