Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tagging submodule "pkg/apis"? #223

Open
Rick-xuy opened this issue Feb 17, 2023 · 1 comment
Open

Consider tagging submodule "pkg/apis"? #223

Rick-xuy opened this issue Feb 17, 2023 · 1 comment

Comments

@Rick-xuy
Copy link

I found that package github.com/rancher/system-upgrade-controller/pkg/apis/upgrade.cattle.io/v1 is placed in submodule github.com/rancher/system-upgrade-controller/pkg/apis instead of root module.

However, it seems that submodule github.com/rancher/system-upgrade-controller/pkg/apis is not tagged. According to Go Modules wiki, submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/rancher/system-upgrade-controller/pkg/apis/upgrade.cattle.io/v1, downstream would depends on pseudo-version of module github.com/rancher/system-upgrade-controller/pkg/apis.

github.com/rancher/system-upgrade-controller/pkg/apis v0.0.0-20210727200656-10b094e30007

I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly. For example, pkg/apis/v0.0.1, pkg/apis/v0.10.0etc, so that other project can use tag to import this module in go.mod.

@brandond
Copy link
Member

As per #102 (comment) we are not currently planning on tagging the submodule. We can discuss doing so at some point, but I want to coordinate that with other projects that currently import it before doing so. The pseudo-version is usable for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants