Skip to content

Commit 46faa3e

Browse files
author
rob
committed
1 parent 85caf8e commit 46faa3e

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ In general, we try and follow the original texts: [PEP 8](https://peps.python.or
5757
### General
5858

5959
- Unless there is a single parameter, passed parameters should be explicit.
60+
- It is almost always better to use `arg_not_supplied` (`from syscore.objects import arg_not_supplied`) as a default argument then resolve it to the appropriate value in the function.
6061
- Type hints should be used, with Unions if required `from typing import Union` and Lists / Dicts ...`from typing import List, Dict`
6162
- Verbose doc strings specifying all the parameters are no longer required (superseded by type hints)
6263

syscore/pandas/pdutils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,6 +754,7 @@ def sumup_business_days_over_pd_series_without_double_counting_of_closing_data(
754754

755755
return joint_data
756756

757+
## FIXME HERE
757758

758759
def replace_all_zeros_with_nan(result: pd.Series) -> pd.Series:
759760
check_result = copy(result)

sysdata/csv/csv_futures_contract_prices.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
class ConfigCsvFuturesPrices:
1818
input_date_index_name: str = "DATETIME"
1919
input_date_format: str = DEFAULT_DATE_FORMAT_FOR_CSV
20-
input_column_mapping: dict = None
20+
input_column_mapping: dict = arg_not_supplied
2121
input_skiprows: int = 0
2222
input_skipfooter: int = 0
2323
apply_multiplier: float = 1.0

0 commit comments

Comments
 (0)