fix robcarver17#1085 by removing functionality

Author: rob

sysbrokers/IB/client/ib_client.py

@@ -150,10 +150,6 @@ def get_instrument_code_from_broker_contract_object(
         instrument_code = self.get_instrument_code_from_broker_identity_for_contract(
             broker_identity
         )
-        if instrument_code is missing_contract:
-            ## WE DON'T RAISE AN ERROR HERE AS IT CAUSES ERROR RECURSION SEE #1085
-
-            return missing_contract
 
         return instrument_code
 
@@ -194,9 +190,6 @@ def broker_identity_for_contract(
             allow_expired=False,
             allow_multiple_contracts=False,
         )
-        if contract_details is missing_contract:
-            ## ## WE DON'T RAISE AN ERROR HERE AS IT CAUSES ERROR RECURSION SEE #1085
-            return missing_contract
 
         return IBInstrumentIdentity(
             ib_code=str(contract_details.contract.symbol),
@@ -217,8 +210,7 @@ def get_contract_details(
         )
 
         if len(contract_details) == 0:
-            ## WE DON'T RAISE AN ERROR HERE AS IT CAUSES ERROR RECURSION SEE #1085
-            return missing_contract
+            raise missingContract
 
         if allow_multiple_contracts:
             return contract_details

sysbrokers/IB/client/ib_contracts_client.py

@@ -596,9 +596,6 @@ def ib_get_contract_chain(
             allow_multiple_contracts=True,
         )
 
-        if new_contract_details_list is missing_contract:
-            raise missingContract
-
         ibcontract_list = [
             contract_details.contract for contract_details in new_contract_details_list
         ]