add exchange to ib position

Author: rob

sysbrokers/IB/client/ib_positions_client.py

@@ -1,6 +1,11 @@
 from syscore.constants import arg_not_supplied
 from sysbrokers.IB.client.ib_client import ibClient
-from sysbrokers.IB.ib_positions import from_ib_positions_to_dict, positionsFromIB
+from sysbrokers.IB.ib_positions import (
+    from_ib_positions_to_dict,
+    positionsFromIB,
+    IBPositionWithExtendedAttr,
+)
+from ib_insync.ib import Position
 
 
 class ibPositionsClient(ibClient):
@@ -32,7 +37,9 @@ def add_exchange_codes_to_list_of_raw_ib_positions(
 
         return raw_positions_with_codes
 
-    def add_exchange_code_to_raw_ib_position(self, raw_ib_position):
+    def add_exchange_code_to_raw_ib_position(
+        self, raw_ib_position: Position
+    ) -> IBPositionWithExtendedAttr:
         try:
             ib_contract = raw_ib_position.contract
             list_of_contract_details = self.ib.reqContractDetails(ib_contract)
@@ -43,6 +50,8 @@ def add_exchange_code_to_raw_ib_position(self, raw_ib_position):
         except:
             exchange_code = ""
 
-        setattr(raw_ib_position, "exchange", exchange_code)
+        new_ib_position = IBPositionWithExtendedAttr.from_ib_position(
+            ib_position=raw_ib_position, exchange=exchange_code
+        )
 
-        return raw_ib_position
+        return new_ib_position

sysbrokers/IB/ib_positions.py

@@ -1,10 +1,29 @@
-import re
+from typing import NamedTuple
+from ib_insync.ib import Position, Contract
 from syscore.genutils import highest_common_factor_for_list, sign
 from syscore.constants import arg_not_supplied
 
 from sysexecution.trade_qty import tradeQuantity
 
 
+class IBPositionWithExtendedAttr(NamedTuple):
+    account: str
+    contract: Contract
+    position: float
+    avgCost: float
+    exchange: str
+
+    @classmethod
+    def from_ib_position(cls, ib_position: Position, exchange: str):
+        return cls(
+            account=ib_position.account,
+            contract=ib_position.contract,
+            avgCost=ib_position.avgCost,
+            position=ib_position.position,
+            exchange=exchange,
+        )
+
+
 def extract_fx_balances_from_account_summary(account_summary) -> dict:
     relevant_tag = "TotalCashBalance"