update flake8 noqa skips with proper syntax

Change-Id: I42ed77f559e3ee5b8c600d98457ee37803ef0ea6

Author: CaselIT

lib/sqlalchemy/connectors/pyodbc.py

@@ -180,7 +180,7 @@ def _get_server_version_info(
         dbapi_con = connection.connection.dbapi_connection
         version: Tuple[Union[int, str], ...] = ()
         r = re.compile(r"[.\-]")
-        for n in r.split(dbapi_con.getinfo(self.dbapi.SQL_DBMS_VER)):  # type: ignore[union-attr]  # noqa E501
+        for n in r.split(dbapi_con.getinfo(self.dbapi.SQL_DBMS_VER)):  # type: ignore[union-attr]  # noqa: E501
             try:
                 version += (int(n),)
             except ValueError:
@@ -215,7 +215,7 @@ def do_set_input_sizes(
     def get_isolation_level_values(
         self, dbapi_connection: interfaces.DBAPIConnection
     ) -> List[_IsolationLevel]:
-        return super().get_isolation_level_values(dbapi_connection) + [  # type: ignore  # noqa E501
+        return super().get_isolation_level_values(dbapi_connection) + [  # type: ignore  # noqa: E501
             "AUTOCOMMIT"
         ]
 

lib/sqlalchemy/dialects/oracle/provision.py

@@ -63,7 +63,7 @@ def stop_test_class_outside_fixtures(config, db, cls):
     try:
         with db.begin() as conn:
             # run magic command to get rid of identity sequences
-            # https://floo.bar/2019/11/29/drop-the-underlying-sequence-of-an-identity-column/  # noqa E501
+            # https://floo.bar/2019/11/29/drop-the-underlying-sequence-of-an-identity-column/  # noqa: E501
             conn.exec_driver_sql("purge recyclebin")
     except exc.DatabaseError as err:
         log.warning("purge recyclebin command failed: %s", err)

lib/sqlalchemy/dialects/postgresql/base.py

@@ -1421,7 +1421,7 @@ def bind_expression(self, bindvalue):
     )
 
 
-"""  # noqa E501
+"""  # noqa: E501
 
 from collections import defaultdict
 import datetime as dt

lib/sqlalchemy/engine/base.py

@@ -2655,7 +2655,7 @@ def _switch_shard(conn, cursor, stmt,
             :meth:`_engine.Engine.get_execution_options`
 
 
-        """  # noqa E501
+        """  # noqa: E501
         return self._option_cls(self, opt)
 
     def get_execution_options(self) -> _ExecuteOptions:

lib/sqlalchemy/engine/cursor.py

@@ -1637,7 +1637,7 @@ def rowcount(self):
 
             :ref:`tutorial_update_delete_rowcount` - in the :ref:`unified_tutorial`
 
-        """  # noqa E501
+        """  # noqa: E501
 
         try:
             return self.context.rowcount

lib/sqlalchemy/engine/result.py

@@ -502,7 +502,7 @@ def _allrows(self) -> List[_RowData]:
                     )
                     for made_row in made_rows
                 ]
-                if sig_row not in uniques and not uniques.add(sig_row)  # type: ignore # noqa E501
+                if sig_row not in uniques and not uniques.add(sig_row)  # type: ignore # noqa: E501
             ]
         else:
             interim_rows = made_rows
@@ -749,7 +749,7 @@ def _column_slices(
         real_result = self._real_result if self._real_result else self
 
         if (
-            real_result._source_supports_scalars  # type: ignore[attr-defined] # noqa E501
+            real_result._source_supports_scalars  # type: ignore[attr-defined] # noqa: E501
             and len(indexes) == 1
         ):
             self._generate_rows = False

lib/sqlalchemy/event/base.py

@@ -319,7 +319,7 @@ def _create_dispatcher_class(
             assert dispatch_target_cls is not None
             if (
                 hasattr(dispatch_target_cls, "__slots__")
-                and "_slots_dispatch" in dispatch_target_cls.__slots__  # type: ignore  # noqa E501
+                and "_slots_dispatch" in dispatch_target_cls.__slots__  # type: ignore  # noqa: E501
             ):
                 dispatch_target_cls.dispatch = slots_dispatcher(cls)
             else:

lib/sqlalchemy/event/legacy.py

@@ -51,7 +51,7 @@ def _legacy_signature(
     def leg(fn: Callable[..., Any]) -> Callable[..., Any]:
         if not hasattr(fn, "_legacy_signatures"):
             fn._legacy_signatures = []  # type: ignore[attr-defined]
-        fn._legacy_signatures.append((since, argnames, converter))  # type: ignore[attr-defined] # noqa E501
+        fn._legacy_signatures.append((since, argnames, converter))  # type: ignore[attr-defined] # noqa: E501
         return fn
 
     return leg

lib/sqlalchemy/ext/associationproxy.py

@@ -1176,7 +1176,7 @@ def contains(self, other: Any, **kw: Any) -> ColumnElement[bool]:
                 **{self.value_attr: other}
             )
 
-    def __eq__(self, obj: Any) -> ColumnElement[bool]:  # type: ignore[override]  # noqa E501
+    def __eq__(self, obj: Any) -> ColumnElement[bool]:  # type: ignore[override]  # noqa: E501
         # note the has() here will fail for collections; eq_()
         # is only allowed with a scalar.
         if obj is None:
@@ -1187,7 +1187,7 @@ def __eq__(self, obj: Any) -> ColumnElement[bool]:  # type: ignore[override]  #
         else:
             return self._comparator.has(**{self.value_attr: obj})
 
-    def __ne__(self, obj: Any) -> ColumnElement[bool]:  # type: ignore[override]  # noqa E501
+    def __ne__(self, obj: Any) -> ColumnElement[bool]:  # type: ignore[override]  # noqa: E501
         # note the has() here will fail for collections; eq_()
         # is only allowed with a scalar.
         return self._comparator.has(
@@ -1203,7 +1203,7 @@ class ColumnAssociationProxyInstance(AssociationProxyInstance[_T]):
     _target_is_object: bool = False
     _is_canonical = True
 
-    def __eq__(self, other: Any) -> ColumnElement[bool]:  # type: ignore[override]  # noqa E501
+    def __eq__(self, other: Any) -> ColumnElement[bool]:  # type: ignore[override]  # noqa: E501
         # special case "is None" to check for no related row as well
         expr = self._criterion_exists(
             self.remote_attr.operate(operators.eq, other)

lib/sqlalchemy/ext/asyncio/scoping.py

@@ -85,7 +85,7 @@ def __init__(self, session_factory, scopefunc):
          the current scope.   A function such as ``asyncio.current_task``
          may be useful here.
 
-        """  # noqa E501
+        """  # noqa: E501
 
         self.session_factory = session_factory
         self.registry = ScopedRegistry(session_factory, scopefunc)

lib/sqlalchemy/ext/asyncio/session.py

@@ -503,7 +503,7 @@ def get_bind(self, mapper=None, clause=None, **kw):
         blocking-style code, which will be translated to implicitly async calls
         at the point of invoking IO on the database drivers.
 
-        """  # noqa E501
+        """  # noqa: E501
 
         return self.sync_session.get_bind(
             mapper=mapper, clause=clause, bind=bind, **kw

lib/sqlalchemy/log.py

@@ -64,10 +64,10 @@ def _qual_logger_name_for_cls(cls: Type["Identified"]) -> str:
 
 def class_logger(cls: Type[_IT]) -> Type[_IT]:
     logger = logging.getLogger(_qual_logger_name_for_cls(cls))
-    cls._should_log_debug = lambda self: logger.isEnabledFor(  # type: ignore[assignment]  # noqa E501
+    cls._should_log_debug = lambda self: logger.isEnabledFor(  # type: ignore[assignment]  # noqa: E501
         logging.DEBUG
     )
-    cls._should_log_info = lambda self: logger.isEnabledFor(  # type: ignore[assignment]  # noqa E501
+    cls._should_log_info = lambda self: logger.isEnabledFor(  # type: ignore[assignment]  # noqa: E501
         logging.INFO
     )
     cls.logger = logger

lib/sqlalchemy/orm/base.py

@@ -616,7 +616,7 @@ def of_type(self, class_):
         def and_(self, *criteria):
             ...
 
-        def any(self, criterion=None, **kwargs):  # noqa A001
+        def any(self, criterion=None, **kwargs):  # noqa: A001
             ...
 
         def has(self, criterion=None, **kwargs):

lib/sqlalchemy/orm/decl_api.py

@@ -249,7 +249,7 @@ class AddressMixin:
         :ref:`orm_declarative_dataclasses_mixin` - illustrates special forms
         for use with Python dataclasses
 
-    """  # noqa E501
+    """  # noqa: E501
 
     if typing.TYPE_CHECKING:
 

lib/sqlalchemy/orm/loading.py

@@ -757,7 +757,7 @@ def _instance_processor(
                         # test.orm.inheritance.test_basic ->
                         # EagerTargetingTest.test_adapt_stringency
                         # OptimizedLoadTest.test_column_expression_joined
-                        # PolymorphicOnNotLocalTest.test_polymorphic_on_column_prop  # noqa E501
+                        # PolymorphicOnNotLocalTest.test_polymorphic_on_column_prop  # noqa: E501
                         #
 
                         adapted_col = adapter.columns[col]

lib/sqlalchemy/pool/base.py

@@ -269,7 +269,7 @@ def _creator(
 
         # mypy seems to get super confused assigning functions to
         # attributes
-        self._invoke_creator = self._should_wrap_creator(creator)  # type: ignore  # noqa E501
+        self._invoke_creator = self._should_wrap_creator(creator)  # type: ignore  # noqa: E501
 
     @_creator.deleter
     def _creator(self) -> None:
@@ -609,7 +609,7 @@ def __init__(self, pool: Pool, connect: bool = True):
     dbapi_connection: Optional[DBAPIConnection]
 
     @property
-    def driver_connection(self) -> Optional[Any]:  # type: ignore[override]  # mypy#4125  # noqa E501
+    def driver_connection(self) -> Optional[Any]:  # type: ignore[override]  # mypy#4125  # noqa: E501
         if self.dbapi_connection is None:
             return None
         else:
@@ -632,7 +632,7 @@ def info(self) -> Dict[str, Any]:  # type: ignore[override]  # mypy#4125
         return {}
 
     @util.memoized_property
-    def record_info(self) -> Optional[Dict[str, Any]]:  # type: ignore[override]  # mypy#4125  # noqa E501
+    def record_info(self) -> Optional[Dict[str, Any]]:  # type: ignore[override]  # mypy#4125  # noqa: E501
         return {}
 
     @classmethod
@@ -1081,7 +1081,7 @@ def invalidate(
         self._is_valid = False
 
     @property
-    def record_info(self) -> Optional[Dict[str, Any]]:  # type: ignore[override]  # mypy#4125  # noqa E501
+    def record_info(self) -> Optional[Dict[str, Any]]:  # type: ignore[override]  # mypy#4125  # noqa: E501
         return self._connection_record.record_info
 
     def cursor(self, *args: Any, **kwargs: Any) -> DBAPICursor:
@@ -1147,7 +1147,7 @@ def __init__(
     _connection_record: Optional[_ConnectionRecord]
 
     @property
-    def driver_connection(self) -> Optional[Any]:  # type: ignore[override]  # mypy#4125  # noqa E501
+    def driver_connection(self) -> Optional[Any]:  # type: ignore[override]  # mypy#4125  # noqa: E501
         if self._connection_record is None:
             return None
         return self._connection_record.driver_connection
@@ -1322,7 +1322,7 @@ def info(self) -> Dict[str, Any]:  # type: ignore[override]  # mypy#4125
             return self._connection_record.info
 
     @property
-    def record_info(self) -> Optional[Dict[str, Any]]:  # type: ignore[override]  # mypy#4125  # noqa E501
+    def record_info(self) -> Optional[Dict[str, Any]]:  # type: ignore[override]  # mypy#4125  # noqa: E501
         if self._connection_record is None:
             return None
         else:

lib/sqlalchemy/pool/events.py

@@ -50,7 +50,7 @@ def my_on_checkout(dbapi_conn, connection_rec, connection_proxy):
         # will associate with engine.pool
         event.listen(engine, 'checkout', my_on_checkout)
 
-    """  # noqa E501
+    """  # noqa: E501
 
     _target_class_doc = "SomeEngineOrPool"
     _dispatch_target = Pool

lib/sqlalchemy/sql/_selectable_constructors.py

@@ -157,7 +157,7 @@ def exists(
         :meth:`_sql.SelectBase.exists` - method to transform a ``SELECT`` to an
         ``EXISTS`` clause.
 
-    """  # noqa E501
+    """  # noqa: E501
 
     return Exists(__argument)
 

lib/sqlalchemy/sql/base.py

@@ -1172,7 +1172,7 @@ def _process_opt(conn, statement, multiparams, params, execution_options):
             :ref:`orm_queryguide_execution_options` - documentation on all
             ORM-specific execution options
 
-        """  # noqa E501
+        """  # noqa: E501
         if "isolation_level" in kw:
             raise exc.ArgumentError(
                 "'isolation_level' execution option may only be specified "

lib/sqlalchemy/sql/crud.py

@@ -430,7 +430,7 @@ def _col_bind_name(col: ColumnClause[Any]) -> str:
         _column_as_key = functools.partial(  # type: ignore
             coercions.expect_as_key, roles.DMLColumnRole
         )
-        _getattr_col_key = _col_bind_name = operator.attrgetter("key")  # type: ignore  # noqa E501
+        _getattr_col_key = _col_bind_name = operator.attrgetter("key")  # type: ignore  # noqa: E501
 
     return _column_as_key, _getattr_col_key, _col_bind_name
 

lib/sqlalchemy/sql/dml.py

@@ -453,7 +453,7 @@ def returning(
 
           :ref:`tutorial_insert_returning` - in the :ref:`unified_tutorial`
 
-        """  # noqa E501
+        """  # noqa: E501
         if self._return_defaults:
             raise exc.InvalidRequestError(
                 "return_defaults() is already configured on this statement"
@@ -610,7 +610,7 @@ def returning_column_descriptions(self) -> List[Dict[str, Any]]:
 
             :ref:`queryguide_inspection` - ORM background
 
-        """  # noqa E501
+        """  # noqa: E501
         meth = DMLState.get_plugin_class(
             self
         ).get_returning_column_descriptions

lib/sqlalchemy/sql/elements.py

@@ -2668,11 +2668,11 @@ def _construct(
         if lcc > 1:
             # multiple elements.  Return regular BooleanClauseList
             # which will link elements against the operator.
-            return cls._construct_raw(operator, convert_clauses)  # type: ignore # noqa E501
+            return cls._construct_raw(operator, convert_clauses)  # type: ignore # noqa: E501
         elif lcc == 1:
             # just one element.  return it as a single boolean element,
             # not a list and discard the operator.
-            return convert_clauses[0]  # type: ignore[no-any-return] # noqa E501
+            return convert_clauses[0]  # type: ignore[no-any-return] # noqa: E501
         else:
             # no elements period.  deprecated use case.  return an empty
             # ClauseList construct that generates nothing unless it has
@@ -2689,7 +2689,7 @@ def _construct(
                 },
                 version="1.4",
             )
-            return cls._construct_raw(operator)  # type: ignore[no-any-return] # noqa E501
+            return cls._construct_raw(operator)  # type: ignore[no-any-return] # noqa: E501
 
     @classmethod
     def _construct_for_whereclause(

lib/sqlalchemy/sql/functions.py

@@ -200,7 +200,7 @@ def scalar_table_valued(self, name, type_=None):
 
             :meth:`_functions.FunctionElement.column_valued`
 
-        """  # noqa E501
+        """  # noqa: E501
 
         return ScalarFunctionColumn(self, name, type_)
 
@@ -270,7 +270,7 @@ def table_valued(self, *expr, **kw):
             :meth:`_sql.TableValuedAlias.render_derived` - renders the alias
             using a derived column clause, e.g. ``AS name(col1, col2, ...)``
 
-        """  # noqa 501
+        """  # noqa: 501
 
         new_func = self._generate()
 
@@ -311,7 +311,7 @@ def column_valued(self, name=None):
 
             :meth:`_functions.FunctionElement.table_valued`
 
-        """  # noqa 501
+        """  # noqa: 501
 
         return self.alias(name=name).column
 
@@ -336,7 +336,7 @@ def columns(self):
             :meth:`_functions.FunctionElement.table_valued` - generates table-valued
             SQL function expressions.
 
-        """  # noqa E501
+        """  # noqa: E501
         return self.c
 
     @util.ro_memoized_property
@@ -1197,19 +1197,19 @@ class coalesce(ReturnTypeFromArgs[_T]):
     inherit_cache = True
 
 
-class max(ReturnTypeFromArgs[_T]):  # noqa  A001
+class max(ReturnTypeFromArgs[_T]):  # noqa:  A001
     """The SQL MAX() aggregate function."""
 
     inherit_cache = True
 
 
-class min(ReturnTypeFromArgs[_T]):  # noqa A001
+class min(ReturnTypeFromArgs[_T]):  # noqa: A001
     """The SQL MIN() aggregate function."""
 
     inherit_cache = True
 
 
-class sum(ReturnTypeFromArgs[_T]):  # noqa A001
+class sum(ReturnTypeFromArgs[_T]):  # noqa: A001
     """The SQL SUM() aggregate function."""
 
     inherit_cache = True

lib/sqlalchemy/sql/operators.py

@@ -417,7 +417,7 @@ def __call__(
         if hasattr(left, "__sa_operate__"):
             return left.operate(self, right, *other, **kwargs)
         elif self.python_impl:
-            return self.python_impl(left, right, *other, **kwargs)  # type: ignore  # noqa E501
+            return self.python_impl(left, right, *other, **kwargs)  # type: ignore  # noqa: E501
         else:
             raise exc.InvalidRequestError(
                 f"Custom operator {self.opstring!r} can't be used with "