Skip to content

Commit 90b2f97

Browse files
committed
update setup.py and CHANGELOG
1 parent 18f8bb0 commit 90b2f97

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

Diff for: CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
* LAML version 0.0.4
2+
* add functionalities to create character matrices from fastq files (borrowed from a module of Cassiopeia)
23
* handle mismatch between character matrix and prior pickle
34
* fix error in doing topology search on multiple input trees
45
* more informative messages on handling polytomies
5-
* LAML version 0.0.3 (depricated)
6+
* LAML version 0.0.3 (deprecated)
67
* attempt to allow user-specified sampling times
78
* seems to work for branch length estimation on a fixed topology, but fails on doing topology search
89
* roll-back to the previous version

Diff for: run_laml.py

100644100755
+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def main():
4040
parser._action_groups.append(otherOptions)
4141

4242
# input arguments
43-
requiredNamed.add_argument("-t","--topology",required=True,help="[REQUIRED] Binary input tree topology in newick format. Branch lengths will be ignored.")
43+
requiredNamed.add_argument("-t","--topology",required=True,help="[REQUIRED] The input tree topology in newick format. Branch lengths will be ignored.")
4444
requiredNamed.add_argument("-c","--characters",required=True,help="[REQUIRED] The input character matrix. Must have header.")
4545

4646
inputOptions.add_argument("-p","--priors",required=False, default="uniform", help="The input prior matrix Q. Default: if not specified, use a uniform prior.")

Diff for: setup.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ def recursive_list_dir(path):
1717
listing.append(z.split(path+'/')[1])
1818
return listing
1919

20+
# Note from GC
21+
# 1. If installing from python setup.py install, please `pip install cvxpy` first.
22+
# 2. SCS requires numpy < 1.2 to be installed: https://github.com/bodono/scs-python/issues/32#issuecomment-802977693
23+
# 3. cvxpy fails to install on python 3.12, requires SCS, ECOS and OSQP: https://github.com/cvxpy/cvxpy/issues/1367
24+
# 4. qdldl (dependency of osqp has no wheel for python 3.12): https://github.com/cvxpy/cvxpy/issues/2269
25+
# 5. osqp < 0.6.2 does not depend on qdldl to install cvxpy
2026

2127
param = {
2228
'name': laml_libs.PROGRAM_NAME,
@@ -30,13 +36,8 @@ def recursive_list_dir(path):
3036
'scripts': ['run_laml.py', 'laml_tests.py', 'extra_laml_tests.py'],
3137
'zip_safe': True,
3238
#'setup_requires': ['numpy'],
33-
# SCS requires numpy < 1.2 to be installed: https://github.com/bodono/scs-python/issues/32#issuecomment-802977693
34-
# cvxpy fails to install on python 3.12, requires SCS, ECOS and OSQP: https://github.com/cvxpy/cvxpy/issues/1367
35-
# qdldl (dependency of osqp has no wheel for python 3.12): https://github.com/cvxpy/cvxpy/issues/2269
36-
# osqp < 0.6.2 does not depend on qdldl to install cvxpy
37-
# NOTE: if installing from python setup.py install, please `pip install cvxpy` first.
38-
'install_requires': ['scipy>=1.3.1', 'cvxpy>=1.4', 'treeswift>=1.1.39', 'Mosek>=10.1.16', 'setuptools'], #, 'treeswift', 'Mosek', 'setuptools', 'scipy==1.11.4', 'scs==3.2.4.post1', 'clarabel==0.7.1'], #'ecos==2.0.13'], #'osqp==0.6.5'], # 'qdldl==0.1.7.post0'], #osqp>=0.6.1', 'ecos>=2', 'clarabel>=0.5.0', 'scs>=3.0', 'cvxpy'],
39-
#'install_requires': ['numpy>=1.16', 'treeswift>=1.1.39', 'scipy>=1.3.1', 'cvxpy>=1.4', 'Mosek>=10.1.16', 'cmake>=3.18.0', 'setuptools', 'pybind11'], #'osqp==0.6.1'],
39+
'install_requires': ['scipy>=1.3.1', 'cvxpy>=1.4', 'treeswift>=1.1.39', 'Mosek>=10.1.16',
40+
'Biopython>=1.71','joblib','matplotlib>=2.2.2','setuptools'],
4041
'keywords': 'Phylogenetics Evolution Computational Maximum-likelihood Lineage Tracing',
4142
'long_description': """LAML is a maximum likelihood algorithm under the Probabilistic Mixed-type Missing (PMM) model. Given a lineage tracing experiment character matrix with heterogeneous per-site alphabets and mutation probabilities, LAML will find a maximum likelihood tree topology and estimate branch lengths as well as stochastic dropout and heritable silencing missing data rates.""",
4243
'classifiers': [

0 commit comments

Comments
 (0)