Add symbol checking in CI (#28)

This PR adds verification that no spdlog or fmt symbols are part of the
dynamic symbol table for the rapids_logger binaries.

Author: vyasr

CMakeLists.txt

@@ -84,7 +84,7 @@ if(RAPIDS_LOGGER_HIDE_ALL_SPDLOG_SYMBOLS)
     FMT_OPTION ${RAPIDS_LOGGER_FMT_OPTION} CPM_ARGS OPTIONS "BUILD_SHARED_LIBS OFF"
                                            "SPDLOG_BUILD_SHARED OFF"
   )
-  set_target_properties(spdlog PROPERTIES CXX_VISIBILITY_PRESET hidden POSITION_INDEPENDENT_CODE ON)
+  set_target_properties(spdlog PROPERTIES POSITION_INDEPENDENT_CODE ON)
   target_link_options(rapids_logger PRIVATE "LINKER:--exclude-libs,libspdlog")
 else()
   rapids_cpm_spdlog(

ci/build_static.sh

@@ -7,6 +7,10 @@ source rapids-date-string
 
 rapids-logger "Static cpp build"
 
+# Make sure we have an updated CMake
+python -m pip install -U cmake
+pyenv rehash
+
 cmake -S . -B build -DBUILD_SHARED_LIBS=OFF -DBUILD_TESTS=ON
 cmake --build build
 ctest --test-dir build --output-on-failure

ci/build_wheel.sh

@@ -5,6 +5,8 @@ set -euo pipefail
 
 package_name="rapids_logger"
 package_dir="python/rapids-logger"
+dist_dir="${package_dir}/dist"
+final_dir="${package_dir}/final_dist"
 
 source rapids-configure-sccache
 
@@ -13,16 +15,22 @@ rapids-generate-version > ./VERSION
 rapids-logger "Building '${package_name}' wheel"
 sccache --zero-stats
 python -m pip wheel \
-    -w "${package_dir}/dist" \
+    -w "${dist_dir}" \
     -v \
     --no-deps \
     --disable-pip-version-check \
     "${package_dir}"
 sccache --show-adv-stats
 
-mkdir -p "${package_dir}/final_dist"
+mkdir -p "${final_dir}"
 python -m auditwheel repair \
-    -w "${package_dir}/final_dist" \
-    ${package_dir}/dist/*
+    -w "${final_dir}" \
+    "${dist_dir}/"*
 
-RAPIDS_PY_WHEEL_NAME="${package_name}" rapids-upload-wheels-to-s3 cpp "${package_dir}/final_dist"
+# Check that no undefined symbols are present in the shared library
+WHEEL_EXPORT_DIR="$(mktemp -d)"
+unzip -d "${WHEEL_EXPORT_DIR}" "${final_dir}/*"
+LOGGER_LIBRARY=$(find "${WHEEL_EXPORT_DIR}" -type f -name 'librapids_logger.so')
+./ci/check_symbols.sh "${LOGGER_LIBRARY}"
+
+RAPIDS_PY_WHEEL_NAME="${package_name}" rapids-upload-wheels-to-s3 cpp "${final_dir}"

ci/check_symbols.sh

@@ -0,0 +1,25 @@
+#!/bin/bash
+# Copyright (c) 2025, NVIDIA CORPORATION.
+
+set -eEuo pipefail
+
+echo "checking for symbol visibility issues"
+
+LIBRARY="${1}"
+
+echo ""
+echo "Checking exported symbols in '${LIBRARY}'"
+symbol_file="./symbols.txt"
+readelf --dyn-syms --wide "${LIBRARY}" \
+    | c++filt \
+    > "${symbol_file}"
+
+for lib in fmt spdlog; do
+    echo "Checking for '${lib}' symbols..."
+    if grep -E "${lib}\:\:" "${symbol_file}"; then
+        echo "ERROR: Found some exported symbols in ${LIBRARY} matching the pattern ${lib}::."
+        exit 1
+    fi
+done
+
+echo "No symbol visibility issues found in ${LIBRARY}"

conda/recipes/rapids-logger/recipe.yaml

@@ -18,6 +18,11 @@ build:
     # Run tests from the build directory since they're cheap.
     ctest --test-dir build/ --output-on-failure
     cmake --install build/
+    # Check that no undefined symbols are present in the shared library
+    LIB="build/librapids_logger.so"
+    test -f "${LIB}"
+    ./ci/check_symbols.sh "${LIB}"
+
 
 requirements:
   build: