Skip to content

Commit 15247b2

Browse files
mairacanalpopcornmix
authored andcommitted
drm/v3d: Don't retrieve the clock twice
Upstream commit d3976b4 ("drm/v3d: Add clock handling") introduced clock handling. Therefore, delete the clock handling previously introduced in downstream. Signed-off-by: Maíra Canal <[email protected]>
1 parent 61c9478 commit 15247b2

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

drivers/gpu/drm/v3d/v3d_drv.c

+8-11
Original file line numberDiff line numberDiff line change
@@ -393,21 +393,18 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
393393
}
394394
}
395395

396-
v3d->clk = devm_clk_get(dev, NULL);
397-
if (IS_ERR_OR_NULL(v3d->clk)) {
398-
if (PTR_ERR(v3d->clk) != -EPROBE_DEFER)
399-
dev_err(dev, "Failed to get clock (%ld)\n", PTR_ERR(v3d->clk));
400-
return PTR_ERR(v3d->clk);
401-
}
402-
403396
node = rpi_firmware_find_node();
404-
if (!node)
405-
return -EINVAL;
397+
if (!node) {
398+
ret = -EINVAL;
399+
goto clk_disable;
400+
}
406401

407402
firmware = rpi_firmware_get(node);
408403
of_node_put(node);
409-
if (!firmware)
410-
return -EPROBE_DEFER;
404+
if (!firmware) {
405+
ret = -EPROBE_DEFER;
406+
goto clk_disable;
407+
}
411408

412409
v3d->clk_up_rate = rpi_firmware_clk_get_max_rate(firmware,
413410
RPI_FIRMWARE_V3D_CLK_ID);

0 commit comments

Comments
 (0)