Skip to content

Commit 2b062ea

Browse files
committed
drm/v3d: Correct clock settng calls to new APIs
There was a report that 6.12 kernel has lower benchmark scores than 6.6. I can confirm, and found it started with 6.8 kernel which moved some code into a new file (v3d_submit.c) and in two places the change to the clock api were missed. The effect of the bug is the v3d clock sometimes unwantedly drops to a lower rate. With this patch the benchmark scores are good again. Fixes: 8696303 Signed-off-by: Dom Cobley <[email protected]>
1 parent 37cb5f7 commit 2b062ea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/v3d/v3d_submit.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ v3d_clock_down_work(struct work_struct *work)
1818
container_of(work, struct v3d_dev, clk_down_work.work);
1919
int ret;
2020

21-
ret = clk_set_rate(v3d->clk, v3d->clk_down_rate);
21+
ret = clk_set_min_rate(v3d->clk, v3d->clk_down_rate);
2222
v3d->clk_up = false;
2323
WARN_ON_ONCE(ret != 0);
2424
}
@@ -32,7 +32,7 @@ v3d_clock_up_get(struct v3d_dev *v3d)
3232
if (!v3d->clk_up) {
3333
int ret;
3434

35-
ret = clk_set_rate(v3d->clk, v3d->clk_up_rate);
35+
ret = clk_set_min_rate(v3d->clk, v3d->clk_up_rate);
3636
WARN_ON_ONCE(ret != 0);
3737
v3d->clk_up = true;
3838
}

0 commit comments

Comments
 (0)