Skip to content

Commit 8d163a9

Browse files
6by9pelwell
authored andcommitted
drm/vc4: tests: Update pv muxing tests now DSI1 is more flexible
The tests on vc4 (BCM2835-7) were checking for DSI1 muxing being to restricted channel 2, and therefore muxing with TXP was impossible. As we no longer have that restriction, update the capabilities defined for DSI1, move the tests that used to be impossible to the valid list, and extend for additional combinations that are now possible. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 2bd2afe commit 8d163a9

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c

+20-4
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static const struct encoder_constraint vc4_encoder_constraints[] = {
9191
ENCODER_CONSTRAINT(VC4_ENCODER_TYPE_HDMI0, 1),
9292
ENCODER_CONSTRAINT(VC4_ENCODER_TYPE_VEC, 1),
9393
ENCODER_CONSTRAINT(VC4_ENCODER_TYPE_TXP0, 2),
94-
ENCODER_CONSTRAINT(VC4_ENCODER_TYPE_DSI1, 2),
94+
ENCODER_CONSTRAINT(VC4_ENCODER_TYPE_DSI1, 0, 1, 2),
9595
};
9696

9797
static const struct encoder_constraint vc5_encoder_constraints[] = {
@@ -258,6 +258,9 @@ static const struct pv_muxing_param vc4_test_pv_muxing_params[] = {
258258
VC4_PV_MUXING_TEST("2 outputs: VEC, DSI1",
259259
VC4_ENCODER_TYPE_VEC,
260260
VC4_ENCODER_TYPE_DSI1),
261+
VC4_PV_MUXING_TEST("2 outputs: TXP, DSI1",
262+
VC4_ENCODER_TYPE_TXP0,
263+
VC4_ENCODER_TYPE_DSI1),
261264
VC4_PV_MUXING_TEST("2 outputs: VEC, TXP",
262265
VC4_ENCODER_TYPE_VEC,
263266
VC4_ENCODER_TYPE_TXP0),
@@ -293,6 +296,22 @@ static const struct pv_muxing_param vc4_test_pv_muxing_params[] = {
293296
VC4_ENCODER_TYPE_DPI,
294297
VC4_ENCODER_TYPE_VEC,
295298
VC4_ENCODER_TYPE_TXP0),
299+
VC4_PV_MUXING_TEST("3 outputs: DSI1, HDMI, TXP",
300+
VC4_ENCODER_TYPE_DSI1,
301+
VC4_ENCODER_TYPE_HDMI0,
302+
VC4_ENCODER_TYPE_TXP0),
303+
VC4_PV_MUXING_TEST("3 outputs: DSI1, VEC, TXP",
304+
VC4_ENCODER_TYPE_DSI1,
305+
VC4_ENCODER_TYPE_VEC,
306+
VC4_ENCODER_TYPE_TXP0),
307+
VC4_PV_MUXING_TEST("3 outputs: DSI1, DPI, TXP",
308+
VC4_ENCODER_TYPE_DSI1,
309+
VC4_ENCODER_TYPE_DPI,
310+
VC4_ENCODER_TYPE_TXP0),
311+
VC4_PV_MUXING_TEST("3 outputs: DSI1, DSI0, TXP",
312+
VC4_ENCODER_TYPE_DSI1,
313+
VC4_ENCODER_TYPE_DSI0,
314+
VC4_ENCODER_TYPE_TXP0),
296315
};
297316

298317
KUNIT_ARRAY_PARAM(vc4_test_pv_muxing,
@@ -303,9 +322,6 @@ static const struct pv_muxing_param vc4_test_pv_muxing_invalid_params[] = {
303322
VC4_PV_MUXING_TEST("DPI/DSI0 Conflict",
304323
VC4_ENCODER_TYPE_DPI,
305324
VC4_ENCODER_TYPE_DSI0),
306-
VC4_PV_MUXING_TEST("TXP/DSI1 Conflict",
307-
VC4_ENCODER_TYPE_TXP0,
308-
VC4_ENCODER_TYPE_DSI1),
309325
VC4_PV_MUXING_TEST("HDMI0/VEC Conflict",
310326
VC4_ENCODER_TYPE_HDMI0,
311327
VC4_ENCODER_TYPE_VEC),

0 commit comments

Comments
 (0)