Skip to content

Commit cd231d4

Browse files
committed
dts: rp1: Don't use DMA with UARTs
DMA has been enabled on RP1's UART0, but with mixed success. Transmits seem to work, but the DMA interface is not well suited to receiving arbitrary amounts of data. In particular, the PL011 driver is slow to pass on the received data, batching it into large blocks. On balance, it's better to just disable the DMA support. As with the other UARTs, the required runes are left in the DTS as comments. Signed-off-by: Phil Elwell <[email protected]>
1 parent 33c5aad commit cd231d4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arch/arm64/boot/dts/broadcom/rp1.dtsi

+3-3
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@
6565
interrupts = <RP1_INT_UART0 IRQ_TYPE_LEVEL_HIGH>;
6666
clocks = <&rp1_clocks RP1_CLK_UART &rp1_clocks RP1_PLL_SYS_PRI_PH>;
6767
clock-names = "uartclk", "apb_pclk";
68-
dmas = <&rp1_dma RP1_DMA_UART0_TX>,
69-
<&rp1_dma RP1_DMA_UART0_RX>;
70-
dma-names = "tx", "rx";
68+
// dmas = <&rp1_dma RP1_DMA_UART0_TX>,
69+
// <&rp1_dma RP1_DMA_UART0_RX>;
70+
// dma-names = "tx", "rx";
7171
pinctrl-names = "default";
7272
arm,primecell-periphid = <0x00341011>;
7373
uart-has-rtscts;

0 commit comments

Comments
 (0)