Skip to content

Commit e0009ab

Browse files
naushirpelwell
authored andcommitted
drivers: media: pisp_be: Remove unused fields in struct pisp_be_config
These fields should not be set by either the user or the kernel driver so remove them. Replace them with padding bytes to maintain backward compatibility with existing userland applications. Signed-off-by: Naushir Patuck <[email protected]>
1 parent 83436b5 commit e0009ab

File tree

1 file changed

+4
-38
lines changed

1 file changed

+4
-38
lines changed

include/uapi/linux/media/raspberrypi/pisp_be_config.h

+4-38
Original file line numberDiff line numberDiff line change
@@ -716,13 +716,6 @@ struct pisp_be_hog_buffer_config {
716716
/**
717717
* struct pisp_be_config - RaspberryPi PiSP Back End Processing configuration
718718
*
719-
* @input_buffer: Input buffer addresses
720-
* @tdn_input_buffer: TDN input buffer addresses
721-
* @stitch_input_buffer: Stitch input buffer addresses
722-
* @tdn_output_buffer: TDN output buffer addresses
723-
* @stitch_output_buffer: Stitch output buffer addresses
724-
* @output_buffer: Output buffers addresses
725-
* @hog_buffer: HOG buffer addresses
726719
* @global: Global PiSP configuration
727720
* @input_format: Input image format
728721
* @decompress: Decompress configuration
@@ -761,28 +754,10 @@ struct pisp_be_hog_buffer_config {
761754
* @output_format: Output format configuration
762755
* @hog: HOG configuration
763756
* @axi: AXI bus configuration
764-
* @lsc_extra: LSC extra info
765-
* @cac_extra: CAC extra info
766-
* @downscale_extra: Downscaler extra info
767-
* @resample_extra: Resample extra info
768-
* @crop: Crop configuration
769-
* @hog_format: HOG format info
770-
* @dirty_flags_bayer: Bayer enable dirty flags
771-
* (:c:type:`pisp_be_bayer_enable`)
772-
* @dirty_flags_rgb: RGB enable dirty flags
773-
* (:c:type:`pisp_be_rgb_enable`)
774-
* @dirty_flags_extra: Extra dirty flags
775757
*/
776758
struct pisp_be_config {
777-
/* I/O configuration: */
778-
struct pisp_be_input_buffer_config input_buffer;
779-
struct pisp_be_tdn_input_buffer_config tdn_input_buffer;
780-
struct pisp_be_stitch_input_buffer_config stitch_input_buffer;
781-
struct pisp_be_tdn_output_buffer_config tdn_output_buffer;
782-
struct pisp_be_stitch_output_buffer_config stitch_output_buffer;
783-
struct pisp_be_output_buffer_config
784-
output_buffer[PISP_BACK_END_NUM_OUTPUTS];
785-
struct pisp_be_hog_buffer_config hog_buffer;
759+
/* For backward compatibility */
760+
uint8_t pad0[112];
786761
/* Processing configuration: */
787762
struct pisp_be_global_config global;
788763
struct pisp_image_format_config input_format;
@@ -823,17 +798,8 @@ struct pisp_be_config {
823798
output_format[PISP_BACK_END_NUM_OUTPUTS];
824799
struct pisp_be_hog_config hog;
825800
struct pisp_be_axi_config axi;
826-
/* Non-register fields: */
827-
struct pisp_be_lsc_extra lsc_extra;
828-
struct pisp_be_cac_extra cac_extra;
829-
struct pisp_be_downscale_extra
830-
downscale_extra[PISP_BACK_END_NUM_OUTPUTS];
831-
struct pisp_be_resample_extra resample_extra[PISP_BACK_END_NUM_OUTPUTS];
832-
struct pisp_be_crop_config crop;
833-
struct pisp_image_format_config hog_format;
834-
__u32 dirty_flags_bayer; /* these use pisp_be_bayer_enable */
835-
__u32 dirty_flags_rgb; /* use pisp_be_rgb_enable */
836-
__u32 dirty_flags_extra; /* these use pisp_be_dirty_t */
801+
/* For backward compatibility */
802+
uint8_t pad1[84];
837803
} __attribute__((packed));
838804

839805
/**

0 commit comments

Comments
 (0)