Skip to content

Commit 9169685

Browse files
authored
Remove second arguments from pico_package_uf2_output functions (#678)
* Remove second arguments from pico_package_uf2_output functions See raspberrypi/pico-sdk#2545 * Clarify universal binary load_map message
1 parent e6d2b4b commit 9169685

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

bootloaders/encrypted/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ pico_embed_pt_in_binary(enc_bootloader ${CMAKE_CURRENT_LIST_DIR}/enc-pt.json)
5050

5151
# create absolute uf2, and package in flash
5252
pico_set_uf2_family(enc_bootloader "absolute")
53-
pico_package_uf2_output(enc_bootloader 0x10000000)
53+
pico_package_uf2_output(enc_bootloader)
5454

5555
# optionally enable USB output in addition to UART
5656
# pico_enable_stdio_usb(enc_bootloader 1)
@@ -86,7 +86,7 @@ pico_hash_binary(hello_serial_enc)
8686
pico_encrypt_binary(hello_serial_enc ${CMAKE_CURRENT_LIST_DIR}/privateaes.bin ${CMAKE_CURRENT_LIST_DIR}/ivsalt.bin)
8787

8888
# package uf2 in flash
89-
pico_package_uf2_output(hello_serial_enc 0x10000000)
89+
pico_package_uf2_output(hello_serial_enc)
9090

9191
# optionally enable USB output in addition to UART
9292
# pico_enable_stdio_usb(hello_serial_enc 1)

bootloaders/uart/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ target_link_libraries(uart_binary pico_stdlib)
2929
pico_set_binary_type(uart_binary no_flash)
3030

3131
# package uf2 in flash
32-
pico_package_uf2_output(uart_binary 0x10000000)
32+
pico_package_uf2_output(uart_binary)
3333

3434
# create map/bin/hex/uf2 file etc.
3535
pico_add_extra_outputs(uart_binary)

encrypted/hello_encrypted/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ pico_encrypt_binary(hello_encrypted
3838
EMBED)
3939

4040
# package uf2 in flash
41-
pico_package_uf2_output(hello_encrypted 0x10000000)
41+
pico_package_uf2_output(hello_encrypted)
4242

4343
# create map/bin/hex/uf2 file etc.
4444
pico_add_extra_outputs(hello_encrypted)
@@ -86,7 +86,7 @@ pico_encrypt_binary(hello_encrypted_mbedtls
8686
OTP_KEY_PAGE 29)
8787

8888
# package uf2 in flash
89-
pico_package_uf2_output(hello_encrypted_mbedtls 0x10000000)
89+
pico_package_uf2_output(hello_encrypted_mbedtls)
9090

9191
# create map/bin/hex/uf2 file etc.
9292
pico_add_extra_outputs(hello_encrypted_mbedtls)

universal/wrapper/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ function(pico_add_extra_outputs TARGET)
5151
if (NOT (PICO_PLATFORM MATCHES rp2040))
5252
get_target_property(BINARY_TYPE ${SOURCE_TARGET} PICO_TARGET_BINARY_TYPE)
5353
if (${BINARY_TYPE} STREQUAL "no_flash")
54-
message("Packaging no_flash universal binary to SRAM, so it has a load_map")
55-
pico_package_uf2_output(${SOURCE_TARGET} 0x20000000)
54+
message("Ensuring no_flash universal binary has a load_map")
55+
# This is required so it is copied to the correct location in SRAM
56+
pico_ensure_load_map(${SOURCE_TARGET})
5657
endif()
5758
endif()
5859
_pico_add_extra_outputs(${SOURCE_TARGET})

0 commit comments

Comments
 (0)