deepcopy in to_dict methods

Author: simonkassel

pystac/catalog.py

@@ -1,5 +1,6 @@
 import os
 import json
+from copy import (deepcopy, copy)
 
 from pystac import STACError
 from pystac import STAC_VERSION
@@ -135,7 +136,7 @@ def to_dict(self, include_self_link=True):
         if self.title is not None:
             d['title'] = self.title
 
-        return d
+        return deepcopy(d)
 
     def clone(self):
         clone = Catalog(id=self.id,

pystac/collection.py

@@ -2,7 +2,7 @@
 from datetime import datetime
 from datetime import timezone
 import dateutil.parser
-from copy import copy
+from copy import (copy, deepcopy)
 import json
 
 from pystac import STACError, STAC_IO
@@ -62,7 +62,7 @@ def to_dict(self, include_self_link=True):
         if self.summaries is not None:
             d['summaries'] = self.summaries
 
-        return d
+        return deepcopy(d)
 
     def clone(self):
         clone = Collection(id=self.id,
@@ -139,11 +139,13 @@ def __init__(self, spatial, temporal):
         self.temporal = temporal
 
     def to_dict(self):
-        return {
+        d = {
             'spatial': self.spatial.to_dict(),
             'temporal': self.temporal.to_dict()
         }
 
+        return deepcopy(d)
+
     def clone(self):
         return Extent(spatial=copy(self.spatial),
                       temporal=copy(self.temporal))
@@ -159,7 +161,8 @@ def __init__(self, bboxes):
         self.bboxes = bboxes
 
     def to_dict(self):
-        return { 'bbox' : self.bboxes }
+        d = { 'bbox' : self.bboxes }
+        return deepcopy(d)
 
     def clone(self):
         return SpatialExtent(self.bboxes)
@@ -214,7 +217,8 @@ def to_dict(self):
 
             encoded_intervals.append([start, end])
 
-        return { 'interval': encoded_intervals }
+        d = {'interval': encoded_intervals}
+        return deepcopy(d)
 
     def clone(self):
         return TemporalExtent(intervals=copy(self.intervals))
@@ -256,7 +260,7 @@ def to_dict(self):
         if self.url is not None:
             d['url'] = self.url
 
-        return d
+        return deepcopy(d)
 
     @staticmethod
     def from_dict(d):

pystac/item.py

@@ -74,7 +74,7 @@ def to_dict(self, include_self_link=True):
 
         assets = dict(map(lambda x: (x[0], x[1].to_dict()), self.assets.items()))
 
-        self.properties['datetime'] = self.datetime.isoformat()
+        self.properties['datetime'] = '{}Z'.format(self.datetime.replace(microsecond=0, tzinfo=None))
 
         d = {
             'type': 'Feature',
@@ -93,7 +93,7 @@ def to_dict(self, include_self_link=True):
         if self.collection:
             d['collection'] = self.collection
 
-        return d
+        return deepcopy(d)
 
     def clone(self):
         clone = Item(id=self.id,
@@ -223,7 +223,7 @@ def to_dict(self):
             for k, v in self.properties.items():
                 d[k] = v
 
-        return d
+        return deepcopy(d)
 
     def clone(self):
         return Asset(href=self.href,

pystac/label.py

@@ -92,7 +92,7 @@ def to_dict(self, include_self_link=True):
         if self.label_overviews is not None:
             d['properties']['label:overviews'] = [ov.to_dict() for ov in self.label_overviews]
 
-        return d
+        return deepcopy(d)
 
     def add_source(self, source_item, title=None, assets=None):
         properties = None

pystac/link.py

@@ -1,5 +1,5 @@
 import os
-from copy import copy
+from copy import (copy, deepcopy)
 from urllib.parse import urlparse
 
 from pystac import STACError
@@ -127,7 +127,7 @@ def to_dict(self):
             for k, v in self.properties.items():
                 d[k] = v
 
-        return d
+        return deepcopy(d)
 
     def clone(self):
         return Link(rel=self.rel,