Stopped Working Properly in the Last Few Days

[RoyiAvital]

Hi,

It seems to stop working properly in the last few days:

• Some cases of new threads aren't marked in green.
• Posts with new comments doesn't write the number of new comments.

Using on Chrome 106.0.5249.62 and TamperMonkey 4.16.1.
On my Chrome TamperMonkey is the only extension and your script is the only script on it.

[raszpl]

Yep. for a quick fix you can manually edit at

hackahackernews/hackahackernews.user.js

Line 45 in 7082c28

if (parseInt(document.querySelectorAll('.subtext > a[href^="item?id='+itemarray[i]+'"]')[0].innerHTML) > parseInt(localStorage.getItem(itemarray[i]).split(' ')[1]))

          //        if (parseInt(document.querySelectorAll('.subtext > a[href^="item?id='+itemarray[i]+'"]')[0].innerHTML) > parseInt(localStorage.getItem(itemarray[i]).split(' ')[1]))
          //      {
          //      let fresh = parseInt(document.querySelectorAll('.subtext > a[href^="item?id='+itemarray[i]+'"]')[0].innerHTML) - parseInt(localStorage.getItem(itemarray[i]).split(' ')[1]);
          //    document.querySelectorAll('.subtext > a[href^="item?id='+itemarray[i]+'"]')[0].innerHTML += '<a class="newcomments"><b> '+fresh+' new</b></a>';
        if (parseInt(document.querySelector('.subtext > span.subline > a[href^="item?id='+itemarray[i]+'"]').innerText) > parseInt(localStorage.getItem(itemarray[i]).split(' ')[1])) {
          let fresh = parseInt(document.querySelector('.subtext > span.subline > a[href^="item?id='+itemarray[i]+'"]').innerText) - parseInt(localStorage.getItem(itemarray[i]).split(' ')[1]);
          document.querySelector('.subtext > span.subline > a[href^="item?id='+itemarray[i]+'"]').innerHTML += ' <a class="hhn_newcomments"><b>'+fresh+' new</b></a>';

Ill update github later with refactored script

[RoyiAvital]

No rush, I will for the updated version.
It should be updated automatically by TamperMonkey, right?

[raszpl]

Just updated.

[RoyiAvital]

I think you didn't update the version which means it won't update.

[RoyiAvital]

OK, now it is updated yet nothing works!

When I look at the code in TamperMonkey it shows:

Mind the error next to case.

[raszpl]

:( im sorry, hopefully third times a charm

[RoyiAvital]

Checking, yet it still says some errors:

Maybe version 0.6.1 :-)?

[RoyiAvital]

Also, the number of new comments used to be red, yet now it is not:

[raszpl]

Those are cosmetic ESLint errors, safe to ignore. Fixed class name, should be red again :)

[RoyiAvital]

OK, I still see cases (Mostly on pages 2, 3, ...) for news I haven't seen or read which are not marked in green.