|
| 1 | +From 0bbcfb08a2e3a6d5fe83c1e58fca23d01fd88a21 Mon Sep 17 00:00:00 2001 |
| 2 | +From: "Suzuki K. Poulose" < [email protected]> |
| 3 | +Date: Tue, 17 Mar 2015 18:14:58 +0000 |
| 4 | +Subject: [PATCH] ARM: perf: reject groups spanning multiple hardware PMUs |
| 5 | + |
| 6 | +The perf core implicitly rejects events spanning multiple HW PMUs, as in |
| 7 | +these cases the event->ctx will differ. However this validation is |
| 8 | +performed after pmu::event_init() is called in perf_init_event(), and |
| 9 | +thus pmu::event_init() may be called with a group leader from a |
| 10 | +different HW PMU. |
| 11 | + |
| 12 | +The ARM PMU driver does not take this fact into account, and when |
| 13 | +validating groups assumes that it can call to_arm_pmu(event->pmu) for |
| 14 | +any HW event. When the event in question is from another HW PMU this is |
| 15 | +wrong, and results in dereferencing garbage. |
| 16 | + |
| 17 | +This patch updates the ARM PMU driver to first test for and reject |
| 18 | +events from other PMUs, moving the to_arm_pmu and related logic after |
| 19 | +this test. Fixes a crash triggered by perf_fuzzer on Linux-4.0-rc2, with |
| 20 | +a CCI PMU present: |
| 21 | + |
| 22 | + --- |
| 23 | +CPU: 0 PID: 1527 Comm: perf_fuzzer Not tainted 4.0.0-rc2 #57 |
| 24 | +Hardware name: ARM-Versatile Express |
| 25 | +task: bd8484c0 ti: be676000 task.ti: be676000 |
| 26 | +PC is at 0xbf1bbc90 |
| 27 | +LR is at validate_event+0x34/0x5c |
| 28 | +pc : [<bf1bbc90>] lr : [<80016060>] psr: 00000013 |
| 29 | +... |
| 30 | +[<80016060>] (validate_event) from [<80016198>] (validate_group+0x28/0x90) |
| 31 | +[<80016198>] (validate_group) from [<80016398>] (armpmu_event_init+0x150/0x218) |
| 32 | +[<80016398>] (armpmu_event_init) from [<800882e4>] (perf_try_init_event+0x30/0x48) |
| 33 | +[<800882e4>] (perf_try_init_event) from [<8008f544>] (perf_init_event+0x5c/0xf4) |
| 34 | +[<8008f544>] (perf_init_event) from [<8008f8a8>] (perf_event_alloc+0x2cc/0x35c) |
| 35 | +[<8008f8a8>] (perf_event_alloc) from [<8009015c>] (SyS_perf_event_open+0x498/0xa70) |
| 36 | +[<8009015c>] (SyS_perf_event_open) from [<8000e420>] (ret_fast_syscall+0x0/0x34) |
| 37 | +Code: bf1be000 bf1bb380 802a2664 00000000 (00000002) |
| 38 | +---[ end trace 01aff0ff00926a0a ]--- |
| 39 | + |
| 40 | +Also cleans up the code to use the arm_pmu only when we know that |
| 41 | +we are dealing with an arm pmu event. |
| 42 | + |
| 43 | +Change-Id: I890a2a685d1ecd462287f19907c3de8bedee2c70 |
| 44 | +Cc: Will Deacon < [email protected]> |
| 45 | +Acked-by: Mark Rutland < [email protected]> |
| 46 | +Acked-by: Peter Ziljstra (Intel) < [email protected]> |
| 47 | +Signed-off-by: Suzuki K. Poulose < [email protected]> |
| 48 | +Signed-off-by: Will Deacon < [email protected]> |
| 49 | +--- |
| 50 | + arch/arm/kernel/perf_event.c | 24 ++++++++++++++++++------ |
| 51 | + 1 file changed, 18 insertions(+), 6 deletions(-) |
| 52 | + |
| 53 | +diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c |
| 54 | +index 5989418ca04..15d45df3fd3 100644 |
| 55 | +--- a/arch/arm/kernel/perf_event.c |
| 56 | ++++ b/arch/arm/kernel/perf_event.c |
| 57 | +@@ -343,19 +343,31 @@ out: |
| 58 | + } |
| 59 | + |
| 60 | + static int |
| 61 | +-validate_event(struct pmu_hw_events *hw_events, |
| 62 | ++validate_event(struct pmu *pmu, struct pmu_hw_events *hw_events, |
| 63 | + struct perf_event *event) |
| 64 | + { |
| 65 | +- struct arm_pmu *armpmu = to_arm_pmu(event->pmu); |
| 66 | ++ struct arm_pmu *armpmu; |
| 67 | + struct hw_perf_event fake_event = event->hw; |
| 68 | + struct pmu *leader_pmu = event->group_leader->pmu; |
| 69 | + |
| 70 | + if (is_software_event(event)) |
| 71 | + return 1; |
| 72 | + |
| 73 | +- if (event->pmu != leader_pmu || event->state <= PERF_EVENT_STATE_OFF) |
| 74 | ++ /* |
| 75 | ++ * Reject groups spanning multiple HW PMUs (e.g. CPU + CCI). The |
| 76 | ++ * core perf code won't check that the pmu->ctx == leader->ctx |
| 77 | ++ * until after pmu->event_init(event). |
| 78 | ++ */ |
| 79 | ++ if (event->pmu != pmu) |
| 80 | ++ return 0; |
| 81 | ++ |
| 82 | ++ if (event->pmu != leader_pmu || event->state < PERF_EVENT_STATE_OFF) |
| 83 | ++ return 1; |
| 84 | ++ |
| 85 | ++ if (event->state == PERF_EVENT_STATE_OFF && !event->attr.enable_on_exec) |
| 86 | + return 1; |
| 87 | + |
| 88 | ++ armpmu = to_arm_pmu(event->pmu); |
| 89 | + return armpmu->get_event_idx(hw_events, &fake_event) >= 0; |
| 90 | + } |
| 91 | + |
| 92 | +@@ -373,15 +385,15 @@ validate_group(struct perf_event *event) |
| 93 | + memset(fake_used_mask, 0, sizeof(fake_used_mask)); |
| 94 | + fake_pmu.used_mask = fake_used_mask; |
| 95 | + |
| 96 | +- if (!validate_event(&fake_pmu, leader)) |
| 97 | ++ if (!validate_event(event->pmu, &fake_pmu, leader)) |
| 98 | + return -EINVAL; |
| 99 | + |
| 100 | + list_for_each_entry(sibling, &leader->sibling_list, group_entry) { |
| 101 | +- if (!validate_event(&fake_pmu, sibling)) |
| 102 | ++ if (!validate_event(event->pmu, &fake_pmu, sibling)) |
| 103 | + return -EINVAL; |
| 104 | + } |
| 105 | + |
| 106 | +- if (!validate_event(&fake_pmu, event)) |
| 107 | ++ if (!validate_event(event->pmu, &fake_pmu, event)) |
| 108 | + return -EINVAL; |
| 109 | + |
| 110 | + return 0; |
| 111 | +-- |
| 112 | +2.13.3 |
| 113 | + |
0 commit comments