Skip to content

Commit 90e6b2a

Browse files
author
Vikash
committed
fix: Check for empty options in case of additional appeal
1 parent c020144 commit 90e6b2a

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

core/appeal/service.go

+8-3
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@ func (s *Service) MakeAction(approvalAction domain.ApprovalAction) (*domain.Appe
250250
if err := s.approvalService.AdvanceApproval(appeal); err != nil {
251251
return nil, err
252252
}
253-
254253
} else if approvalAction.Action == domain.AppealActionNameReject {
255254
approval.Reject()
256255
appeal.Reject()
@@ -726,8 +725,14 @@ func (s *Service) isEligibleToExtend(a *domain.Appeal, p *domain.Provider, activ
726725
}
727726

728727
now := s.TimeNow()
729-
activeAppealExpDate := activeAppealsMap[a.AccountID][a.ResourceID][a.Role].Options.ExpirationDate
730-
isEligibleForExtension := activeAppealExpDate.Sub(now) <= duration
728+
appeal := activeAppealsMap[a.AccountID][a.ResourceID][a.Role]
729+
var isEligibleForExtension bool
730+
if appeal.Options != nil && appeal.Options.ExpirationDate != nil {
731+
activeAppealExpDate := appeal.Options.ExpirationDate
732+
isEligibleForExtension = activeAppealExpDate.Sub(now) <= duration
733+
} else {
734+
isEligibleForExtension = true
735+
}
731736
return isEligibleForExtension, nil
732737
}
733738
}

0 commit comments

Comments
 (0)