.NET 9 (#222)

* net 9 compiles

* build and test pipelines use dotnet 9

* dotnet 9.0.x for build and test workflows

* CHANGELOG.md: update

* add dotnet8/9 versions of testReferenceWorks to make sure there are no regressions for dotnet/8 LTS

---------

Co-authored-by: Saulius Menkevičius <[email protected]>

Author: lapponiandevil

.github/workflows/build.yaml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-24.04]
-        dotnet: [8.0.404]
+        dotnet: [9.0.x]
     runs-on: ${{ matrix.os }}
 
     steps:

.github/workflows/test.yaml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest, ubuntu-24.04]
-        dotnet: [8.0.404]
+        dotnet: [9.0.x]
       fail-fast: false
 
     runs-on: ${{ matrix.os }}

CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
+* csharp-ls will now use and require .NET 8 runtime/SDK
+  - PR by @lapponiandevil in https://github.com/razzmatazz/csharp-language-server/pull/222
 * Upgrade Ionide.LanguageServerProtocol to 0.7.0:
   - https://github.com/razzmatazz/csharp-language-server/pull/221
 * Reduce startup notifications by using "window/logMessage"

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.400",
+    "version": "9.0.1",
     "rollForward": "minor"
   }
 }

src/CSharpLanguageServer/CSharpLanguageServer.fsproj

@@ -3,7 +3,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Description>C# LSP language server</Description>
     <PackAsTool>true</PackAsTool>
     <ToolCommandName>csharp-ls</ToolCommandName>

src/CSharpLanguageServer/Handlers/Workspace.fs

@@ -82,11 +82,11 @@ module Workspace =
             match Path.GetExtension(change.Uri) with
             | ".csproj" ->
                 do! context.WindowShowMessage "change to .csproj detected, will reload solution"
-                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5)))
+                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5:int64)))
 
             | ".sln" ->
                 do! context.WindowShowMessage "change to .sln detected, will reload solution"
-                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5)))
+                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5:int64)))
 
             | ".cs" ->
                 match change.Type with

tests/CSharpLanguageServer.Tests/CSharpLanguageServer.Tests.fsproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
 
     <IsPackable>false</IsPackable>
     <GenerateProgramFile>false</GenerateProgramFile>

tests/CSharpLanguageServer.Tests/ReferenceTests.fs

@@ -5,10 +5,10 @@ open Ionide.LanguageServerProtocol.Types
 
 open CSharpLanguageServer.Tests.Tooling
 
-[<TestCase>]
-let testReferenceWorks() =
-    use client = setupServerClient defaultClientProfile
-                                   "TestData/testReferenceWorks"
+[<TestCase("TestData/dotnet9TestReferenceWorks")>]
+[<TestCase("TestData/dotnet8TestReferenceWorks")>]
+let testReferenceWorks(testDataDir: string) =
+    use client = setupServerClient defaultClientProfile testDataDir
     client.StartAndWaitForSolutionLoad()
 
     use classFile = client.Open("Project/Class.cs")