Very slow in a large solution.

[carlosalarconb]

Any suggestion ? my solution has 380 projects :( . thanks!

[razzmatazz]

is the loading of the solution slow or just some of the operations?

[carlosalarconb]

loading the solution, it takes around 20 minutes .

[razzmatazz]

do you have log from your lsp client/editor? csharp-lsp will fall back to loading each project sequentially if sln file cannot be found or if there is more than one

[razzmatazz]

Basically, in case there are multiple sln files in your project, please specify a value for csharp.solution configuration variable (https://github.com/razzmatazz/csharp-language-server?tab=readme-ov-file#settings) or pass in "-s " arg to the server.

[AdamWawrzynkowskiGF]

Same for me, I have specified the csharp.solution but it's still crazy slow for very huge solutions. For example, DotRush is loading this in around 1min

After 5mins:

[AdeAttwood]

After diving into another issue, I found something that could help with this.

For @AdamWawrzynkowskiGF issues this looks like the csharp.solution option is working correctly, this loading n projects message only comes when there are multiple solution files found, so that's probably a bit different.

When loading the actual projects individually (note this is the codepath where multiple solution files are found) I started getting the following error.

[serverEventLoop] could not OpenProjectAsync('Path\\To\\My.csproj'):
    System.AggregateException: One or more errors occurred. ('My.Namespace(net8.0)' is already part of the workspace.)

    System.ArgumentException: 'My.Namespace(net8.0)' is already part of the workspace
    at Microsoft.CodeAnalysis.Workspace.CheckProjectIsNotInSolution(Solution solution, ProjectId projectId)
    at Microsoft.CodeAnalysis.Workspace.CheckAndAddProject(Solution newSolution, ProjectInfo project)
    at Microsoft.CodeAnalysis.Workspace.<>c__DisplayClass55_0.<OnProjectAdded>b__0(Solution oldSolution)

What looks to be happening is, when you load a project into the msbuild workspace, it also loads the dependencies. If one of the dependences is another one of your projects, when it tries to load that project, it fails to load. Maybe something could be done there.

[razzmatazz]

I have added (very) rudimentary heuristics to select a .sln file when user has not specified one in #250

Otherwise adding+selecting a .sln file is recommended to make initial startup faster as it uses internal roslyn machinery to resolve cross-project deps and what else there is..

[thedeany]

I saw the fix was released in 0.19.0 yesterday; I've updated to it and the solution I have which would take multiple minutes on 0.18.0 is now loading much more quickly. I haven't timed it yet, but it's definitely faster!