Skip to content

Commit d54010b

Browse files
committed
virtio-devices: vhost_user: fs: Don't reference packed struct
error: reference to packed field is unaligned --> virtio-devices/src/vhost_user/fs.rs:85:21 | 85 | fs.flags[i].bits() as i32, | ^^^^^^^^^^^ | = note: `-D unaligned-references` implied by `-D warnings` = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #82523 <rust-lang/rust#82523> = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced) Signed-off-by: Rob Bradford <[email protected]>
1 parent dfc7d6a commit d54010b

File tree

1 file changed

+2
-1
lines changed
  • virtio-devices/src/vhost_user

1 file changed

+2
-1
lines changed

virtio-devices/src/vhost_user/fs.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,12 @@ impl VhostUserMasterReqHandler for SlaveReqHandler {
7878
}
7979

8080
let addr = self.mmap_cache_addr + offset;
81+
let flags = fs.flags[i];
8182
let ret = unsafe {
8283
libc::mmap(
8384
addr as *mut libc::c_void,
8485
len as usize,
85-
fs.flags[i].bits() as i32,
86+
flags.bits() as i32,
8687
libc::MAP_SHARED | libc::MAP_FIXED,
8788
fd,
8889
fs.fd_offset[i] as libc::off_t,

0 commit comments

Comments
 (0)