Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Commit 21a2bfc

Browse files
committed
Fix code style inconsistencies
1 parent 2499e6d commit 21a2bfc

24 files changed

+89
-73
lines changed

honey-common/src/dev/shiza/honey/adventure/AdventureHoneyBuilder.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,25 @@
11
package dev.shiza.honey.adventure;
22

33
import dev.shiza.honey.builder.HoneyBaseBuilder;
4+
import dev.shiza.honey.builder.HoneyBuilder;
45
import dev.shiza.honey.message.MessageCompiler;
56
import net.kyori.adventure.text.Component;
7+
import net.kyori.adventure.text.minimessage.MiniMessage;
68

79
final class AdventureHoneyBuilder extends HoneyBaseBuilder<Component, AdventureHoney> {
810

9-
AdventureHoneyBuilder(final MessageCompiler<Component> messageCompiler) {
11+
private AdventureHoneyBuilder(final MessageCompiler<Component> messageCompiler) {
1012
super(messageCompiler);
1113
}
1214

15+
public static HoneyBuilder<Component, AdventureHoney> builder() {
16+
return new AdventureHoneyBuilder(AdventureMessageCompilerFactory.create());
17+
}
18+
19+
public static HoneyBuilder<Component, AdventureHoney> builder(final MiniMessage miniMessage) {
20+
return new AdventureHoneyBuilder(AdventureMessageCompilerFactory.create(miniMessage));
21+
}
22+
1323
@Override
1424
public AdventureHoney build() {
1525
return new AdventureHoneyImpl(

honey-common/src/dev/shiza/honey/adventure/AdventureHoneyFactory.java

Lines changed: 0 additions & 18 deletions
This file was deleted.

honey-common/src/dev/shiza/honey/adventure/AdventureHoneyImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.util.function.Consumer;
1313
import net.kyori.adventure.text.Component;
1414

15-
class AdventureHoneyImpl extends HoneyImpl<Component> implements AdventureHoney {
15+
final class AdventureHoneyImpl extends HoneyImpl<Component> implements AdventureHoney {
1616

1717
AdventureHoneyImpl(
1818
final MessageCompiler<Component> messageCompiler,

honey-common/src/dev/shiza/honey/adventure/AdventureMessageCompiler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import net.kyori.adventure.text.minimessage.tag.resolver.TagResolver;
1313
import org.intellij.lang.annotations.Subst;
1414

15-
class AdventureMessageCompiler implements MessageCompiler<Component> {
15+
final class AdventureMessageCompiler implements MessageCompiler<Component> {
1616

1717
private final MiniMessage miniMessage;
1818

honey-common/src/dev/shiza/honey/builder/HoneyBaseBuilder.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,12 @@
66
import dev.shiza.honey.placeholder.evaluator.PlaceholderContext;
77
import dev.shiza.honey.placeholder.evaluator.PlaceholderEvaluator;
88
import dev.shiza.honey.placeholder.resolver.PlaceholderResolver;
9+
import dev.shiza.honey.placeholder.resolver.PlaceholderResolverFactory;
910
import dev.shiza.honey.placeholder.sanitizer.PlaceholderSanitizer;
11+
import dev.shiza.honey.placeholder.sanitizer.PlaceholderSanitizerFactory;
1012
import dev.shiza.honey.processor.ProcessorRegistry;
11-
import dev.shiza.honey.reflection.ReflectivePlaceholderEvaluatorFactory;
13+
import dev.shiza.honey.processor.ProcessorRegistryFactory;
14+
import dev.shiza.honey.placeholder.evaluator.reflection.ReflectivePlaceholderEvaluatorFactory;
1215
import org.jetbrains.annotations.ApiStatus.Internal;
1316

1417
@Internal
@@ -44,10 +47,10 @@ protected HoneyBaseBuilder(final MessageCompiler<T> messageCompiler) {
4447
messageCompiler,
4548
ImplicitConversion.create(),
4649
PlaceholderContext.create(),
47-
PlaceholderResolver.create(),
48-
PlaceholderSanitizer.create(),
50+
PlaceholderResolverFactory.create(),
51+
PlaceholderSanitizerFactory.create(),
4952
ReflectivePlaceholderEvaluatorFactory.create(),
50-
ProcessorRegistry.create());
53+
ProcessorRegistryFactory.create());
5154
}
5255

5356
@Override

honey-common/src/dev/shiza/honey/conversion/ImplicitConversion.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ public static ImplicitConversion create(final ImplicitConversionUnit... units) {
2626

2727
public <T> T convert(final Object value) {
2828
Object currentValue = value;
29+
if (currentValue == null) {
30+
return null;
31+
}
2932

3033
boolean conversionFound;
3134
do {

honey-common/src/dev/shiza/honey/placeholder/evaluator/PlaceholderContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.util.Map;
77
import java.util.concurrent.CompletableFuture;
88

9-
public class PlaceholderContext {
9+
public final class PlaceholderContext {
1010

1111
private final Map<String, Object> values;
1212
private final Map<String, CompletableFuture<?>> promisedValues;

honey-common/src/dev/shiza/honey/reflection/ReflectivePlaceholderEvaluationException.java renamed to honey-common/src/dev/shiza/honey/placeholder/evaluator/reflection/ReflectivePlaceholderEvaluationException.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package dev.shiza.honey.reflection;
1+
package dev.shiza.honey.placeholder.evaluator.reflection;
22

3-
public class ReflectivePlaceholderEvaluationException extends RuntimeException {
3+
public final class ReflectivePlaceholderEvaluationException extends RuntimeException {
44

55
public ReflectivePlaceholderEvaluationException(final String message) {
66
super(message);

honey-common/src/dev/shiza/honey/reflection/ReflectivePlaceholderEvaluator.java renamed to honey-common/src/dev/shiza/honey/placeholder/evaluator/reflection/ReflectivePlaceholderEvaluator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package dev.shiza.honey.reflection;
1+
package dev.shiza.honey.placeholder.evaluator.reflection;
22

33
import dev.shiza.honey.placeholder.evaluator.EvaluatedPlaceholder;
44
import dev.shiza.honey.placeholder.evaluator.PlaceholderContext;
@@ -13,7 +13,7 @@
1313
import java.util.regex.Matcher;
1414
import java.util.regex.Pattern;
1515

16-
class ReflectivePlaceholderEvaluator implements PlaceholderEvaluator {
16+
final class ReflectivePlaceholderEvaluator implements PlaceholderEvaluator {
1717

1818
private static final Pattern PATH_PATTERN = Pattern.compile("([a-zA-Z_]\\w*)");
1919
private static final MethodHandles.Lookup LOOKUP = MethodHandles.lookup();

honey-common/src/dev/shiza/honey/reflection/ReflectivePlaceholderEvaluatorFactory.java renamed to honey-common/src/dev/shiza/honey/placeholder/evaluator/reflection/ReflectivePlaceholderEvaluatorFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
package dev.shiza.honey.reflection;
1+
package dev.shiza.honey.placeholder.evaluator.reflection;
22

33
import dev.shiza.honey.placeholder.evaluator.PlaceholderEvaluator;
44

55
public final class ReflectivePlaceholderEvaluatorFactory {
66

7-
ReflectivePlaceholderEvaluatorFactory() {}
7+
private ReflectivePlaceholderEvaluatorFactory() {}
88

99
public static PlaceholderEvaluator create() {
1010
return new ReflectivePlaceholderEvaluator();

0 commit comments

Comments
 (0)